Skip to content

Commit e8be982

Browse files
committed
Fix bugs and improve examples
1 parent c4a24af commit e8be982

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

JavaScript/1-extract-metadata/1-filter-simple.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ const filter = names => {
2525
const name = names[i];
2626
if (
2727
name.length >= 10 && name.length <= 200 &&
28-
name.indexOf('Mich') > -1 &&
29-
name.indexOf('V') === 0 &&
30-
name.slice(-2) === 'ov' &&
28+
name.includes('Mich') &&
29+
name.startsWith('V') &&
30+
name.endsWith('ov') &&
3131
!(
3232
name.length >= 50 && name.length <= 65 &&
33-
name.indexOf('Abu') > -1 &&
34-
name.indexOf('Lev') === 0 &&
35-
name.slice(-3) === 'iov'
33+
name.includes('Abu') &&
34+
name.startsWith('Lev') &&
35+
name.endsWith('iov')
3636
)
3737
) result.push(name);
3838
}

JavaScript/1-extract-metadata/2-metaprogramming.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const filter = (names, conditions) => {
3939
const check = (s, conditions) => {
4040
let valid = true;
4141
for (const key in conditions) {
42-
valid &= operations[key](s, conditions[key]);
42+
valid = valid && operations[key](s, conditions[key]);
4343
}
4444
return valid;
4545
};

0 commit comments

Comments
 (0)