Skip to content

Update package-lock.json. Configure CI to Keep Lock File Updated #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grant opened this issue Jul 31, 2020 · 2 comments
Closed

Update package-lock.json. Configure CI to Keep Lock File Updated #161

grant opened this issue Jul 31, 2020 · 2 comments

Comments

@grant
Copy link
Contributor

grant commented Jul 31, 2020

It looks like our package-lock.json file is outdated, which caused a sizable diff (from the lock file) when installing this package. #160

Should we configure renovate or something to prevent this?
@grant
Copy link
Contributor Author

grant commented Jul 31, 2020

For example, https://github.com/googleapis/google-api-nodejs-client/blob/master/renovate.json

@hdp617
Copy link
Contributor

hdp617 commented Jul 31, 2020

Should we configure renovate or something to prevent this?

SGTM. I think I set up renovate a while back but I forgot to enable it. I think we can reopen this PR #65

@grant grant mentioned this issue Jul 31, 2020
Merged
1 task
@hdp617 hdp617 closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grant @hdp617