Skip to content

Commit 45bd215

Browse files
authored
Fix convert to copy the dependency install script in the correct cases (#64)
The install script should be copied when there is a package.json with or without the framework dependency, not when there is not package.json.
1 parent 0cab53f commit 45bd215

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

converter/convert

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ if [[ ! -f functions/package.json ]]; then
1818
echo 'Handling functions without package.json'
1919
cp /converter/without-package/package.json .
2020
cp /converter/without-package/package-lock.json .
21-
cp /converter/install-function-dependencies .
2221
ln -s node_modules/.bin/functions-framework start-functions-framework
2322
elif ! cat functions/package.json | jq -e ".dependencies.\"@google-cloud/functions-framework\""; then
2423
echo 'Handling functions with package.json without dependency on @google-cloud/functions-framework'
@@ -30,6 +29,7 @@ else
3029
echo 'Handling functions with package.json with dependency on functions-framework'
3130
cp /converter/with-package-with-framework/package.json .
3231
cp /converter/with-package-with-framework/package-lock.json .
32+
cp /converter/install-function-dependencies .
3333
ln -s functions/node_modules/.bin/functions-framework start-functions-framework
3434
fi
3535

0 commit comments

Comments
 (0)