Skip to content

Feature request: text prompt #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
symonsoft opened this issue Aug 30, 2018 · 9 comments
Closed

Feature request: text prompt #41

symonsoft opened this issue Aug 30, 2018 · 9 comments

Comments

@symonsoft
Copy link

I think it will be useful to have ability to prompt for text information in a single (single/multiple line) text field.
Is it likely to implement such a feature?

@symonsoft
Copy link
Author

Oh I see after some code investigation that it's almost possible with:

let options = {
  message: 'Prompt title',
  verification: '',
  verificationHelp: 'Prompt message'
}

this.$dialog.open('prompt', options)
  .then((dialog) => {
    console.log('Input text: ' + dialog.data)  // always null
  })

But dialog.data is always null....
Then requesting dialog.data for input text and something simplier like:

this.$dialog.prompt('Prompt message')
    .then((dialog) => {
      console.log('Input text: ' + dialog.data)
    })

I think it would be a very useful feature.

@jlsjonas
Copy link

that's actually what a "prompt" is in a javascript context... which it claims to have but actually doesn't support

https://developer.mozilla.org/en-US/docs/Web/API/Window/prompt

@Godofbrowser
Copy link
Owner

Hi, I've been tight on schedule. I'll try to implement this feature this weekend

@symonsoft
Copy link
Author

@Godofbrowser Please, don't forget and abandon your thankful users! We still hope for the release.

@jlsjonas
Copy link

@symonsoft as he has shown interest in implementing it, but is just too tight on schedule; maybe you could make a PR for it? 😉 (I'm using dialog from Buefy for my purposes, as we were using Bulma styling already anyway)

@Godofbrowser
Copy link
Owner

So sorry guys, i'm currently adding this feature. I'm hoping an hour would be enough

@jlsjonas
Copy link

That also works :)

No problem, we all have lives besides open source code too ;)

@Godofbrowser
Copy link
Owner

Godofbrowser commented Nov 20, 2018

Meaanwhile, this can be done easily with custom view. i have a sample implementation (basic) where i'm using a custom view to show a cropper for photo uploads.

https://snag.gy/OVAHkd.jpg

https://snag.gy/Q3RZjB.jpg

https://snag.gy/O6YMXz.jpg

https://snag.gy/CxVNg9.jpg

@Godofbrowser
Copy link
Owner

#48 Will resolve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants