Removing variable custom_tick_pos and adding test

Author: GiuPassarelli

doc/source/whatsnew/v0.25.2.rst

@@ -69,7 +69,7 @@ I/O
 Plotting
 ^^^^^^^^
 
-- Fixed xticks in :core.py: `BarPlot._post_plot_logic` when setting a custom xticks
+-
 -
 -
 

doc/source/whatsnew/v1.0.0.rst

@@ -171,6 +171,7 @@ Plotting
 - Bug in :meth:`DataFrame.plot` producing incorrect legend markers when plotting multiple series on the same axis (:issue:`18222`)
 - Bug in :meth:`DataFrame.plot` when ``kind='box'`` and data contains datetime or timedelta data. These types are now automatically dropped (:issue:`22799`)
 - Bug in :meth:`DataFrame.plot.line` and :meth:`DataFrame.plot.area` produce wrong xlim in x-axis (:issue:`27686`, :issue:`25160`, :issue:`24784`)
+- Bug in :core.py:`BarPlot._decorate_ticks` xticks argument has no effect in bar plot (:issue:`14119`)
 
 Groupby/resample/rolling
 ^^^^^^^^^^^^^^^^^^^^^^^^

pandas/plotting/_matplotlib/core.py

@@ -1310,7 +1310,6 @@ def __init__(self, data, **kwargs):
         pos = kwargs.pop("position", 0.5)
         kwargs.setdefault("align", "center")
         self.tick_pos = np.arange(len(data))
-        self.custom_tick_pos = kwargs.pop("xticks", None)
 
         self.bottom = kwargs.pop("bottom", 0)
         self.left = kwargs.pop("left", 0)
@@ -1437,8 +1436,8 @@ def _post_plot_logic(self, ax, data):
     def _decorate_ticks(self, ax, name, ticklabels, start_edge, end_edge):
         ax.set_xlim((start_edge, end_edge))
 
-        if self.custom_tick_pos is not None:
-            ax.set_xticks(np.array(self.custom_tick_pos))
+        if self.xticks is not None:
+            ax.set_xticks(np.array(self.xticks))
         else:
             ax.set_xticks(self.tick_pos)
             ax.set_xticklabels(ticklabels)

pandas/tests/plotting/test_series.py

@@ -871,6 +871,13 @@ def test_xticklabels(self):
         exp = ["P{i:02d}".format(i=i) for i in [0, 3, 5, 9]]
         self._check_text_labels(ax.get_xticklabels(), exp)
 
+    def test_xtick_barPlot(self):
+        # GH28172
+        s = pd.Series(range(10), index=["P{i:02d}".format(i=i) for i in range(10)])
+        ax = s.plot.bar(xticks=range(0, 11, 2))
+        exp = np.array(list(range(0, 11, 2)))
+        assert (exp == ax.get_xticks()).all()
+
     def test_custom_business_day_freq(self):
         # GH7222
         from pandas.tseries.offsets import CustomBusinessDay