Skip to content

Commit 9ab77e9

Browse files
committed
doc: inform about untrimmed name and email
1 parent 38e1055 commit 9ab77e9

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

gix-actor/src/lib.rs

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,13 @@ pub mod signature;
2828
#[derive(Default, PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone)]
2929
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
3030
pub struct Identity {
31-
/// The actors name.
31+
/// The actors name, potentially with whitespace as parsed.
32+
///
33+
/// Use [IdentityRef::trim()] or trim manually to be able to clean it up.
3234
pub name: BString,
33-
/// The actor's email.
35+
/// The actor's email, potentially with whitespace as parsed.
36+
///
37+
/// Use [IdentityRef::trim()] or trim manually to be able to clean it up.
3438
pub email: BString,
3539
}
3640

@@ -51,9 +55,13 @@ pub struct IdentityRef<'a> {
5155
#[derive(Default, PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone)]
5256
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
5357
pub struct Signature {
54-
/// The actors name.
58+
/// The actors name, potentially with whitespace as parsed.
59+
///
60+
/// Use [SignatureRef::trim()] or trim manually to be able to clean it up.
5561
pub name: BString,
56-
/// The actor's email.
62+
/// The actor's email, potentially with whitespace as parsed.
63+
///
64+
/// Use [SignatureRef::trim()] or trim manually to be able to clean it up.
5765
pub email: BString,
5866
/// The time stamp at which the signature is performed.
5967
pub time: Time,
@@ -65,10 +73,14 @@ pub struct Signature {
6573
#[derive(Default, PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone, Copy)]
6674
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
6775
pub struct SignatureRef<'a> {
68-
/// The actor's name.
76+
/// The actors name, potentially with whitespace as parsed.
77+
///
78+
/// Use [SignatureRef::trim()] or trim manually to be able to clean it up.
6979
#[cfg_attr(feature = "serde", serde(borrow))]
7080
pub name: &'a BStr,
71-
/// The actor's email.
81+
/// The actor's email, potentially with whitespace as parsed.
82+
///
83+
/// Use [SignatureRef::trim()] or trim manually to be able to clean it up.
7284
pub email: &'a BStr,
7385
/// The time stamp at which the signature was performed.
7486
pub time: gix_date::Time,

0 commit comments

Comments
 (0)