Skip to content

Commit 067e7d2

Browse files
committed
Clarify comment and code style
1 parent b2ce048 commit 067e7d2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ jobs:
8989
- uses: taiki-e/install-action@v2
9090
with:
9191
tool: nextest
92-
- name: "Test (nextest)"
92+
- name: Test (nextest)
9393
id: nextest
9494
env:
95-
GIX_TEST_IGNORE_ARCHIVES: 1
95+
GIX_TEST_IGNORE_ARCHIVES: '1'
9696
run: cargo nextest --profile=with-xml run --workspace --no-fail-fast
9797
continue-on-error: true
9898
- name: Check for errors
@@ -101,7 +101,7 @@ jobs:
101101
if ($junit_xml.testsuites.errors -ne 0) { exit 1 }
102102
- name: Collect actual failures
103103
run: |
104-
[xml]$junit_xml = Get-Content 'target/nextest/with-xml/junit.xml'
104+
[xml]$junit_xml = Get-Content -Path 'target/nextest/with-xml/junit.xml'
105105
106106
$actual_failures = $junit_xml.SelectNodes("//testcase[failure]") |
107107
ForEach-Object { "$($_.classname) $($_.name)" } |
@@ -128,8 +128,8 @@ jobs:
128128
Set-Content -Path 'expected-failures.txt' -Value $expected_failures
129129
- name: Compare expected and actual failures
130130
run: |
131-
# Fail the check if there are any differences, even unexpectedly passing tests, so they can be
132-
# investigated. (If this check is made blocking for PRs, this exact check may need to be changed.)
131+
# Fail on any differences, even unexpectedly passing tests, so they can be investigated.
132+
# (If the job is made blocking for PRs, it may make sense to make this less stringent.)
133133
git --no-pager diff --no-index --exit-code --unified=1000000 --color=always -- `
134134
expected-failures.txt actual-failures.txt
135135

0 commit comments

Comments
 (0)