Skip to content

Crashlytics - iOS - setCustomKey - wrong parameters order #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alaegin opened this issue Jun 2, 2024 · 3 comments · Fixed by #646
Closed

Crashlytics - iOS - setCustomKey - wrong parameters order #520

alaegin opened this issue Jun 2, 2024 · 3 comments · Fixed by #646

Comments

@alaegin
Copy link

alaegin commented Jun 2, 2024

Hello!

I started using setCustomKey in the Crashlytics library.
Unfortunately, the current implementation has some serious issue: the order of parameters in setCustomKey is wrong.

Here is the code from my app:

.distinctUntilChanged()
.onEach { balance ->
    logger.i("Setting balance in Crashlytics: $balance")
    Firebase.crashlytics.setCustomKey("balance", balance)
}

Here is the result in Crashlytics report:
image

Here is the Firebase documentation:
image

It seems like the current implementation was done wrong because of the difference between Android (key, value) and iOS (value, key) Firebase libraries.

@nbransby
Copy link
Member

nbransby commented Jun 3, 2024

Sounds like you know how to fix it! Any chance of a PR?

@alaegin
Copy link
Author

alaegin commented Jun 3, 2024

@nbransby Hah, I'll take a look

@kaidotarma
Copy link
Contributor

kaidotarma commented Oct 13, 2024

Noticed the same issue.
Here is the fix PR: #646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants