Skip to content

Commit a1c9f57

Browse files
authored
Merge pull request #603 from GitLiveApp/android-imports
Added fixes for imports.
2 parents 0c6f408 + 8e2d6a0 commit a1c9f57

File tree

8 files changed

+20
-17
lines changed

8 files changed

+20
-17
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,4 +329,3 @@ More recently, with the official SDK for Android providing better support for Ko
329329
For contributors this means following these points when adding new code to the public API of this project:
330330
- **Match the [Android SDKs API](https://firebase.google.com/docs/reference/kotlin/packages).** When adding new API coverage use the Android SDK as the guide on what the public API should be in regard to naming, parameters etc. The goal here is *near binary compatibility*, meaning code consuming the Android SDK compiles *as is* with the Kotlin SDK after just changing the package imports from `com.google` to `dev.gitlive`.
331331
- **Follow our [Kotlin-first design](https://github.com/GitLiveApp/firebase-kotlin-sdk/?tab=readme-ov-file#kotlin-first-design) principles when needed.** If the API you are adding coverage for is new, and it's Kotlin-first in the Android SDK, then you can simply just match the Android SDKs API as described in the first point, but if it's an older Java-first API then ideally we would include an identical API for API compatibility *plus* a Kotlin-first overload. A good example for this is where the Builder pattern is employed in the Android SDK, here we can follow [this Kotlin-first design principle](https://github.com/GitLiveApp/firebase-kotlin-sdk/?tab=readme-ov-file#default-arguments) and provide both methods, one taking the options created with the builder and an overload with default arguments to avoid the builder boilerplate for developers not porting an existing android code base.
332-

firebase-auth/api/android/firebase-auth.api

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public final class dev/gitlive/firebase/auth/AuthTokenResult {
8585
}
8686

8787
public final class dev/gitlive/firebase/auth/CredentialsKt {
88-
public static final fun getAndroid (Lcom/google/firebase/auth/OAuthProvider;)Lcom/google/firebase/auth/OAuthProvider;
88+
public static final fun getAndroid (Ldev/gitlive/firebase/auth/OAuthProvider;)Lcom/google/firebase/auth/OAuthProvider;
8989
}
9090

9191
public final class dev/gitlive/firebase/auth/EmailAuthProvider {

firebase-auth/src/androidMain/kotlin/dev/gitlive/firebase/auth/credentials.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package dev.gitlive.firebase.auth
66

77
import android.app.Activity
88
import com.google.firebase.FirebaseException
9-
import com.google.firebase.auth.OAuthProvider
9+
import com.google.firebase.auth.OAuthProvider as AndroidOAuthProvider
1010
import com.google.firebase.auth.PhoneAuthOptions
1111
import com.google.firebase.auth.PhoneAuthProvider
1212
import kotlinx.coroutines.CompletableDeferred
@@ -52,17 +52,17 @@ public actual object GoogleAuthProvider {
5252
}
5353
}
5454

55-
public val OAuthProvider.android: OAuthProvider get() = android
55+
public val OAuthProvider.android: AndroidOAuthProvider get() = android
5656

57-
public actual class OAuthProvider(internal val android: OAuthProvider) {
57+
public actual class OAuthProvider(internal val android: AndroidOAuthProvider) {
5858

5959
public actual constructor(
6060
provider: String,
6161
scopes: List<String>,
6262
customParameters: Map<String, String>,
6363
auth: FirebaseAuth,
6464
) : this(
65-
OAuthProvider
65+
AndroidOAuthProvider
6666
.newBuilder(provider, auth.android)
6767
.setScopes(scopes)
6868
.addCustomParameters(customParameters)
@@ -71,7 +71,7 @@ public actual class OAuthProvider(internal val android: OAuthProvider) {
7171

7272
public actual companion object {
7373
public actual fun credential(providerId: String, accessToken: String?, idToken: String?, rawNonce: String?): OAuthCredential {
74-
val builder = OAuthProvider.newCredentialBuilder(providerId)
74+
val builder = AndroidOAuthProvider.newCredentialBuilder(providerId)
7575
accessToken?.let { builder.setAccessToken(it) }
7676
idToken?.let { builder.setIdToken(it) }
7777
rawNonce?.let { builder.setIdTokenWithRawNonce(idToken!!, it) }
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package dev.gitlive.firebase.firestore.internal
22

3-
import com.google.firebase.firestore.FirebaseFirestore
43
import java.util.concurrent.ConcurrentHashMap
54
import java.util.concurrent.Executor
65

76
// Since on iOS Callback threads are set as settings, we store the settings explicitly here as well
8-
internal val callbackExecutorMap = ConcurrentHashMap<FirebaseFirestore, Executor>()
7+
internal val callbackExecutorMap = ConcurrentHashMap<com.google.firebase.firestore.FirebaseFirestore, Executor>()

firebase-perf/api/android/firebase-perf.api

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,14 @@ public final class dev/gitlive/firebase/perf/metrics/Trace {
2828
public final fun updateSession (Ldev/gitlive/firebase/perf/session/PerfSession;)V
2929
}
3030

31+
public final class dev/gitlive/firebase/perf/metrics/TraceKt {
32+
public static final fun getAndroid (Ldev/gitlive/firebase/perf/metrics/Trace;)Lcom/google/firebase/perf/metrics/Trace;
33+
}
34+
3135
public final class dev/gitlive/firebase/perf/session/PerfSession {
3236
}
3337

3438
public final class dev/gitlive/firebase/perf/session/PerfSessionKt {
35-
public static final fun getAndroid (Lcom/google/firebase/perf/session/PerfSession;)Lcom/google/firebase/perf/session/PerfSession;
39+
public static final fun getAndroid (Ldev/gitlive/firebase/perf/session/PerfSession;)Lcom/google/firebase/perf/session/PerfSession;
3640
}
3741

firebase-perf/src/androidMain/kotlin/dev/gitlive/firebase/perf/metrics/Trace.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package dev.gitlive.firebase.perf.metrics
22

3-
import com.google.firebase.perf.metrics.Trace
3+
import com.google.firebase.perf.metrics.Trace as AndroidTrace
44
import dev.gitlive.firebase.perf.session.PerfSession
55

6-
public actual class Trace internal constructor(private val android: Trace) {
6+
public val Trace.android: AndroidTrace get() = android
7+
8+
public actual class Trace internal constructor(internal val android: AndroidTrace) {
79

810
public actual fun start() {
911
android.start()

firebase-perf/src/androidMain/kotlin/dev/gitlive/firebase/perf/performance.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package dev.gitlive.firebase.perf
22

3-
import com.google.firebase.FirebaseException
43
import dev.gitlive.firebase.Firebase
54
import dev.gitlive.firebase.FirebaseApp
65
import dev.gitlive.firebase.android as publicAndroid
@@ -25,4 +24,4 @@ public actual class FirebasePerformance(internal val android: com.google.firebas
2524
}
2625
}
2726

28-
public actual open class FirebasePerformanceException(message: String) : FirebaseException(message)
27+
public actual open class FirebasePerformanceException(message: String) : com.google.firebase.FirebaseException(message)
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package dev.gitlive.firebase.perf.session
22

3-
import com.google.firebase.perf.session.PerfSession
3+
import com.google.firebase.perf.session.PerfSession as AndroidPerfSession
44

5-
public val PerfSession.android: PerfSession get() = android
5+
public val PerfSession.android: AndroidPerfSession get() = android
66

7-
public class PerfSession internal constructor(internal val android: PerfSession)
7+
public class PerfSession internal constructor(internal val android: AndroidPerfSession)

0 commit comments

Comments
 (0)