Skip to content

Commit 876c65d

Browse files
committed
remove non-existing Firebase Analytics js methods
1 parent ad0f20b commit 876c65d

File tree

2 files changed

+14
-21
lines changed

2 files changed

+14
-21
lines changed

firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt

+13-15
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import dev.gitlive.firebase.FirebaseApp
55
import dev.gitlive.firebase.FirebaseException
66
import dev.gitlive.firebase.analytics.externals.getAnalytics
77
import dev.gitlive.firebase.js
8-
import kotlinx.coroutines.await
98
import kotlin.time.Duration
109

1110
public actual val Firebase.analytics: FirebaseAnalytics
@@ -25,7 +24,6 @@ public actual class FirebaseAnalytics(internal val js: dev.gitlive.firebase.anal
2524
}
2625

2726
public actual fun setUserProperty(name: String, value: String) {
28-
dev.gitlive.firebase.analytics.externals.setUserProperty(js, name, value)
2927
}
3028

3129
public actual fun setUserId(id: String?) {
@@ -37,30 +35,30 @@ public actual class FirebaseAnalytics(internal val js: dev.gitlive.firebase.anal
3735
}
3836

3937
public actual fun setSessionTimeoutInterval(sessionTimeoutInterval: Duration) {
40-
dev.gitlive.firebase.analytics.externals.setSessionTimeoutInterval(js, sessionTimeoutInterval.inWholeMilliseconds)
4138
}
4239

43-
public actual suspend fun getSessionId(): Long? = rethrow { dev.gitlive.firebase.analytics.externals.getSessionId(js).await() }
40+
public actual suspend fun getSessionId(): Long? = rethrow {
41+
TODO("not yet implemented")
42+
}
4443

4544
public actual fun resetAnalyticsData() {
46-
dev.gitlive.firebase.analytics.externals.resetAnalyticsData(js)
4745
}
4846

4947
public actual fun setDefaultEventParameters(parameters: Map<String, String>) {
5048
dev.gitlive.firebase.analytics.externals.setDefaultEventParameters(js, parameters)
5149
}
5250

5351
public actual fun setConsent(consentSettings: Map<ConsentType, ConsentStatus>) {
54-
val consent = dev.gitlive.firebase.analytics.externals.ConsentSettings()
55-
consentSettings.forEach {
56-
when (it.key) {
57-
ConsentType.AD_PERSONALIZATION -> consent.ad_personalization = it.value.name
58-
ConsentType.AD_STORAGE -> consent.ad_storage = it.value.name
59-
ConsentType.AD_USER_DATA -> consent.ad_user_data = it.value.name
60-
ConsentType.ANALYTICS_STORAGE -> consent.analytics_storage = it.value.name
61-
}
62-
}
63-
dev.gitlive.firebase.analytics.externals.setConsent(js, consent)
52+
// val consent = object : dev.gitlive.firebase.analytics.externals.ConsentSettings {}
53+
// consentSettings.forEach {
54+
// when (it.key) {
55+
// ConsentType.AD_PERSONALIZATION -> consent.ad_personalization = it.value.name
56+
// ConsentType.AD_STORAGE -> consent.ad_storage = it.value.name
57+
// ConsentType.AD_USER_DATA -> consent.ad_user_data = it.value.name
58+
// ConsentType.ANALYTICS_STORAGE -> consent.analytics_storage = it.value.name
59+
// }
60+
// }
61+
// dev.gitlive.firebase.analytics.externals.setConsent(js, consent)
6462
}
6563

6664
public actual enum class ConsentType {

firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/externals/analytics.kt

+1-6
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,18 @@
55
package dev.gitlive.firebase.analytics.externals
66

77
import dev.gitlive.firebase.externals.FirebaseApp
8-
import kotlin.js.Promise
98

109
public external fun getAnalytics(app: FirebaseApp? = definedExternally): FirebaseAnalytics
1110

1211
public external fun logEvent(app: FirebaseAnalytics, name: String, parameters: Map<String, Any>?)
13-
public external fun setUserProperty(app: FirebaseAnalytics, name: String, value: String)
1412
public external fun setUserId(app: FirebaseAnalytics, id: String?)
15-
public external fun resetAnalyticsData(app: FirebaseAnalytics)
1613
public external fun setDefaultEventParameters(app: FirebaseAnalytics, parameters: Map<String, String>)
1714
public external fun setAnalyticsCollectionEnabled(app: FirebaseAnalytics, enabled: Boolean)
18-
public external fun setSessionTimeoutInterval(app: FirebaseAnalytics, sessionTimeoutInterval: Long)
19-
public external fun getSessionId(app: FirebaseAnalytics): Promise<Long?>
2015
public external fun setConsent(app: FirebaseAnalytics, consentSettings: ConsentSettings)
2116

2217
public external interface FirebaseAnalytics
2318

24-
public external class ConsentSettings {
19+
public external interface ConsentSettings {
2520
public var ad_personalization: String?
2621
public var ad_storage: String?
2722
public var ad_user_data: String?

0 commit comments

Comments
 (0)