Fix Android's lies

Author: agonper

demo/app/tests/internal/activity-recognition/recognizers/low-res/android/recognizer.android.ts

@@ -85,6 +85,9 @@ describe("Android low resolution activity recognizer", () => {
 
     it("allows to start the recognition by activating the underlying subsystem", async () => {
         spyOn(recognizerManager, "startListening");
+        spyOn(recognizerState, "isActive")
+            .withArgs(recognizerType)
+            .and.returnValue(Promise.resolve(false));
         await recognizer.startRecognizing(startOptions);
         expect(recognizerManager.startListening).toHaveBeenCalled();
         expect(recognizerState.markAsActive).toHaveBeenCalledWith(
@@ -93,6 +96,16 @@ describe("Android low resolution activity recognizer", () => {
         );
     });
 
+    it("allows to restart the recognition without overwriting existing state", async () => {
+        spyOn(recognizerManager, "startListening");
+        spyOn(recognizerState, "isActive")
+            .withArgs(recognizerType)
+            .and.returnValue(Promise.resolve(true));
+        await recognizer.startRecognizing(startOptions);
+        expect(recognizerManager.startListening).toHaveBeenCalled();
+        expect(recognizerState.markAsActive).not.toHaveBeenCalled();
+    });
+
     it("does not mark the recognizer as active if the activation fails", async () => {
         const listenError = new Error("Could not start listening");
         spyOn(recognizerManager, "startListening").and.rejectWith(listenError);

demo/app/tests/internal/activity-recognition/recognizers/medium-res/android/recognizer.android.ts

@@ -85,6 +85,9 @@ describe("Android medium resolution activity recognizer", () => {
 
     it("allows to start the recognition by activating the underlying subsystem", async () => {
         spyOn(recognizerManager, "startListening");
+        spyOn(recognizerState, "isActive")
+            .withArgs(recognizerType)
+            .and.returnValue(Promise.resolve(false));
         await recognizer.startRecognizing(startOptions);
         expect(recognizerManager.startListening).toHaveBeenCalled();
         expect(recognizerState.markAsActive).toHaveBeenCalledWith(
@@ -93,6 +96,16 @@ describe("Android medium resolution activity recognizer", () => {
         );
     });
 
+    it("allows to restart the recognition without overwriting existing state", async () => {
+        spyOn(recognizerManager, "startListening");
+        spyOn(recognizerState, "isActive")
+            .withArgs(recognizerType)
+            .and.returnValue(Promise.resolve(true));
+        await recognizer.startRecognizing(startOptions);
+        expect(recognizerManager.startListening).toHaveBeenCalled();
+        expect(recognizerState.markAsActive).not.toHaveBeenCalled();
+    });
+
     it("does not mark the recognizer as active if the activation fails", async () => {
         const listenError = new Error("Could not start listening");
         spyOn(recognizerManager, "startListening").and.rejectWith(listenError);

src/internal/activity-recognition/recognizers/abstract-manager.android.ts

@@ -46,7 +46,7 @@ export abstract class AndroidAbstractRecognizerManager
 
   async startListening(options: StartOptions = {}): Promise<void> {
     if (this.isUp()) {
-      return;
+      await this.stopListening();
     }
 
     if (!this.isReady()) {

src/internal/activity-recognition/recognizers/abstract-recognizer.ts

@@ -33,6 +33,10 @@ export abstract class AbstractActivityRecognizer implements ActivityRecognizer {
 
   async startRecognizing(options: StartOptions = {}): Promise<void> {
     await this.recognitionManager.startListening(options);
+    const active = await this.recognizerState.isActive(this.recognizerType);
+    if (active) {
+      return;
+    }
     await this.recognizerState.markAsActive(this.recognizerType, options);
   }
 

src/package-lock.json

@@ -1,6 +1,6 @@
 {
 	"name": "nativescript-context-apis",
-	"version": "1.0.1",
+	"version": "1.0.2",
 	"description": "Painless access to contextual information for your NativeScript apps",
 	"main": "context-apis",
 	"typings": "index.d.ts",