Merge pull request #24 from GeoTecINIT/upgrade-ns-geolocation

Upgrade ns geolocation

Author: agonper

README.md

@@ -22,6 +22,8 @@ What we plan to offer in the future:
 
 ### Android only
 
+#### Google Play Services conflicts
+
 Given that we rely on [nativescript-geolocation](https://github.com/NativeScript/nativescript-geolocation) and use Google Play Services APIs for activity detection on Android devices, you might find Google Play Services version conflicts with other installed plugins.
 
 In order to avoid them, we advise you to force a specific Google Play Services version. For a better human activity detection functionality, version 17 or above is highly recommended. In order to do so, please, indicate the Google Play Services Version number in your `app/App_Resources/Android/before-plugins.gradle` file (if the file does not exist, just create it):
@@ -36,6 +38,26 @@ android {
 }
 ```
 
+#### Permissions
+
+In order to use geolocation on Android, you'll need to add the following permission(s) to your app's `AndroidManifest.xml` inside the `App_Resources/Android/src/main` dir:
+
+```xml
+  <!-- Always include this permission -->
+  <!-- This permission is for "approximate" location data -->
+  <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
+
+  <!-- Include only if your app benefits from precise location access. -->
+  <!-- This permission is for "precise" location data -->
+  <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
+
+  <!-- Required only when requesting background location access on
+       Android 10 (API level 29) and higher. -->
+  <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />
+```
+
+More information can be found in the [Android docs here](https://developer.android.com/training/location/permissions).
+
 > Source: [https://github.com/NativeScript/nativescript-geolocation](https://github.com/NativeScript/nativescript-geolocation)
 
 ## Installation
@@ -45,7 +67,7 @@ Run the following command in your project's root folder.
 NS7+:
 
 ```javascript
-tns plugin add nativescript-context-apis
+ns plugin add nativescript-context-apis
 ```
 
 NS6:

azure-pipelines.yml

@@ -15,13 +15,19 @@ pool:
 steps:
 - task: NodeTool@0
   inputs:
-    versionSpec: '10.x'
+    versionSpec: '16.x'
   displayName: 'Install Node.js'
 
+- task: JavaToolInstaller@0
+  inputs:
+    versionSpec: '11'
+    jdkArchitectureOption: 'x64'
+    jdkSourceOption: 'PreInstalled'
+
 - script: |
-    echo no | npm install -g nativescript@7
-    tns usage-reporting disable
-    tns error-reporting disable
+    echo no | npm install -g nativescript
+    ns usage-reporting disable
+    ns error-reporting disable
   displayName: 'Install NativeScript CLI'
 
 - script: |
@@ -33,13 +39,13 @@ steps:
 - script: |
     cd demo
     npm install
-    tns build android --bundle --env.uglify --env.snapshot
+    ns build android --bundle --env.uglify --env.snapshot
   displayName: 'Build'
 
 - script: |
     ./ci-tools/wait-for-emulator.sh
     cd demo
-    tns test android --watch false --justlaunch
+    ns test android --watch false --justlaunch
   displayName: 'Test'
 
 - task: PublishTestResults@2

ci-tools/wait-for-emulator.sh

@@ -1,10 +1,10 @@
 #!/usr/bin/env bash
 
 # Install AVD files
-echo "y" | $ANDROID_HOME/tools/bin/sdkmanager --install 'system-images;android-27;google_apis;x86'
+echo "y" | $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --install 'system-images;android-30;google_apis;x86'
 
 # Create emulator
-echo "no" | $ANDROID_HOME/tools/bin/avdmanager create avd -n xamarin_android_emulator -k 'system-images;android-27;google_apis;x86' --force
+echo "no" | $ANDROID_HOME/cmdline-tools/latest/bin/avdmanager create avd -n xamarin_android_emulator -k 'system-images;android-30;google_apis;x86' --force
 
 $ANDROID_HOME/emulator/emulator -list-avds
 

demo/app/App_Resources/Android/app.gradle

@@ -12,8 +12,10 @@
 android {
   // todo: remove once ndk 23+ is supported
   ndkVersion "22.1.7171670"
+  compileSdkVersion 30
   defaultConfig {
     minSdkVersion 19
+    targetSdkVersion 30
     generatedDensities = []
   }
   aaptOptions {

demo/app/App_Resources/Android/src/main/AndroidManifest.xml

@@ -10,6 +10,18 @@
 		android:largeScreens="true"
 		android:xlargeScreens="true"/>
 
+	<!-- Always include this permission -->
+	<!-- This permission is for "approximate" location data -->
+	<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
+
+	<!-- Include only if your app benefits from precise location access. -->
+	<!-- This permission is for "precise" location data -->
+	<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
+
+	<!-- Required only when requesting background location access on
+         Android 10 (API level 29) and higher. -->
+	<uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />
+
 	<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
 	<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
 	<uses-permission android:name="android.permission.INTERNET"/>