Skip to content

Commit bef7cbb

Browse files
authored
Merge pull request #3 from FullStacksDev/small-fixes
Small fixes
2 parents f55e3ff + eb4d49d commit bef7cbb

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

app/src/app/logbook/data/db/config.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class ConfigService {
1616
getConfig$(): Observable<Config> {
1717
const objectRef = ref(this.#rtdb, 'config');
1818
return object$(objectRef).pipe(
19-
tap((change) => logger.debug('#getConfig config change snapshot from RTDB:', change)),
19+
tap((change) => logger.debug('#getConfig$ - config change snapshot from RTDB:', change)),
2020
map((change) => {
2121
const data = change.snapshot.val();
2222

app/src/app/logbook/data/db/entries.service.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,16 @@ export class EntriesService {
5656
pageCursor: PageCursor,
5757
filters: EntriesFilters,
5858
): Observable<EntryDoc[]> {
59-
logger.debug('#getEntries inputs:', { userId, pageSize, pageCursor, filters });
59+
logger.debug('#getEntryDocs$ - inputs:', { userId, pageSize, pageCursor, filters });
6060

6161
const q = this.#buildQuery(userId, pageSize, pageCursor, filters);
6262
return collectionData$(q).pipe(
63-
tap((entries) => logger.debug('#getEntries entries from Firestore:', entries)),
63+
tap((entries) => logger.debug('#getEntryDocs$ - entries from Firestore:', entries)),
6464
);
6565
}
6666

6767
createEntryDoc$(userId: string, data: NewOrUpdatedEntryInput): Observable<string> {
68-
logger.debug('#addEntry inputs:', { userId, data });
68+
logger.debug('#createEntryDoc$ - inputs:', { userId, data });
6969

7070
const docData = {
7171
...data,
@@ -79,15 +79,15 @@ export class EntriesService {
7979
}
8080

8181
updateEntryDoc$(entryId: string, data: NewOrUpdatedEntryInput): Observable<void> {
82-
logger.debug('#updateEntry inputs:', { entryId, data });
82+
logger.debug('#updateEntryDoc$ - inputs:', { entryId, data });
8383

8484
const docRef = doc(this.#collectionRef, entryId);
8585
const promise = updateDoc(docRef, data);
8686
return from(promise);
8787
}
8888

8989
deleteEntryDoc$(entryId: string): Observable<void> {
90-
logger.debug('#deleteEntry entryId:', entryId);
90+
logger.debug('#deleteEntryDoc$ - entryId:', entryId);
9191

9292
const docRef = doc(this.#collectionRef, entryId);
9393
const promise = deleteDoc(docRef);

app/src/app/logbook/data/entries-update.store.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,3 @@
1-
type EntriesUpdateState = {
2-
processing: boolean;
3-
error: string | null;
4-
};
5-
6-
const initialState: EntriesUpdateState = {
7-
processing: false,
8-
error: null,
9-
};
10-
11-
const logger = createLogger('EntriesUpdateStore');
12-
131
import { Injectable, effect, inject } from '@angular/core';
142
import { AuthStore } from '@app-shared/auth/data/auth.store';
153
import { createLogger } from '@app-shared/logger';
@@ -27,6 +15,18 @@ import { rxMethod } from '@ngrx/signals/rxjs-interop';
2715
import { EMPTY, concatMap, pipe, tap } from 'rxjs';
2816
import { EntriesService } from './db/entries.service';
2917

18+
type EntriesUpdateState = {
19+
processing: boolean;
20+
error: string | null;
21+
};
22+
23+
const initialState: EntriesUpdateState = {
24+
processing: false,
25+
error: null,
26+
};
27+
28+
const logger = createLogger('EntriesUpdateStore');
29+
3030
const _EntriesUpdateStore = signalStore(
3131
withState(initialState),
3232
withMethods((store) => {

app/src/app/shared/auth/data/auth.store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ const _AuthStore = signalStore(
126126
@Injectable({ providedIn: 'root' })
127127
export class AuthStore extends _AuthStore {
128128
readonly waitUntilConnected$ = toObservable(this.status).pipe(
129-
tap((status) => logger.log('waitUntilConnected - status =', status)),
129+
tap((status) => logger.log('waitUntilConnected$ - status =', status)),
130130
filter((status) => status === 'connected'),
131131
shareReplay(1),
132132
);

0 commit comments

Comments
 (0)