Avoid network buffer leak in FreeRTOS_ND.c (#1074)

* Avoid network buffer leak in FreeRTOS_ND.c

* Updat unit tests

---------

Co-authored-by: Tony Josi <[email protected]>

Author: htibosch

source/FreeRTOS_ND.c

@@ -592,6 +592,7 @@
         MACAddress_t xMultiCastMacAddress;
         NetworkBufferDescriptor_t * pxDescriptor = pxNetworkBuffer;
         NetworkBufferDescriptor_t * pxNewDescriptor = NULL;
+        BaseType_t xReleased = pdFALSE;
 
         if( ( pxEndPoint != NULL ) && ( pxEndPoint->bits.bIPv6 != pdFALSE_UNSIGNED ) )
         {
@@ -675,8 +676,14 @@
 
                 /* This function will fill in the eth addresses and send the packet */
                 vReturnEthernetFrame( pxDescriptor, pdTRUE );
+                xReleased = pdTRUE;
             }
         }
+
+        if( ( pxDescriptor != NULL ) && ( xReleased == pdFALSE ) )
+        {
+            vReleaseNetworkBufferAndDescriptor( pxDescriptor );
+        }
     }
 /*-----------------------------------------------------------*/
 

test/unit-test/FreeRTOS_ND/FreeRTOS_ND_utest.c

@@ -690,6 +690,7 @@ void test_vNDAgeCache_NSNullEP( void )
     xNDCache[ xUseEntry ].pxEndPoint = NULL;
 
     pxGetNetworkBufferWithDescriptor_ExpectAnyArgsAndReturn( &xNetworkBuffer );
+    vReleaseNetworkBufferAndDescriptor_Expect( &xNetworkBuffer );
 
     vNDAgeCache();
 
@@ -814,6 +815,8 @@ void test_vNDSendNeighbourSolicitation_NULL_EP( void )
 
     xNetworkBuffer.pxEndPoint = NULL;
 
+    vReleaseNetworkBufferAndDescriptor_Expect( &xNetworkBuffer );
+
     vNDSendNeighbourSolicitation( &xNetworkBuffer, &xIPAddress );
 }
 
@@ -830,6 +833,7 @@ void test_vNDSendNeighbourSolicitation_bIPv6_NotSet( void )
     xEndPoint.bits.bIPv6 = pdFALSE;
     xNetworkBuffer.pxEndPoint = &xEndPoint;
 
+    vReleaseNetworkBufferAndDescriptor_Expect( &xNetworkBuffer );
 
     vNDSendNeighbourSolicitation( &xNetworkBuffer, &xIPAddress );
 }