Skip to content

Commit 1aa18c3

Browse files
gregmagolanFrederikSchlemmer
authored andcommitted
build(bazel): remove workaround no longer needed for module names for ngfactory & ngsummary files (angular#25604)
Workaround was added in angular#25335. It was necessary for .ngfactory & .ngsummary files to have proper AMD module names starting with @angular when building angular downstream from source using Bazel. The underlying issue has been resolved in the compiler and these files now get proper AMD module names without the need for this workaround. The workaround had an unexpected consequence angular/angular-cli#11835 which is fixed by its removal. PR Close angular#25604
1 parent 9d06869 commit 1aa18c3

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

packages/compiler/src/aot/summary_resolver.ts

-10
Original file line numberDiff line numberDiff line change
@@ -120,16 +120,6 @@ export class AotSummaryResolver implements SummaryResolver<StaticSymbol> {
120120
summaries.forEach((summary) => this.summaryCache.set(summary.symbol, summary));
121121
if (moduleName) {
122122
this.knownFileNameToModuleNames.set(filePath, moduleName);
123-
if (filePath.endsWith('.d.ts')) {
124-
// Also add entries to map the ngfactory & ngsummary files to their module names.
125-
// This is necessary to resolve ngfactory & ngsummary files to their AMD module
126-
// names when building angular with Bazel from source downstream.
127-
// See https://github.com/bazelbuild/rules_typescript/pull/223 for context.
128-
this.knownFileNameToModuleNames.set(
129-
filePath.replace(/\.d\.ts$/, '.ngfactory.d.ts'), moduleName + '.ngfactory');
130-
this.knownFileNameToModuleNames.set(
131-
filePath.replace(/\.d\.ts$/, '.ngsummary.d.ts'), moduleName + '.ngsummary');
132-
}
133123
}
134124
importAs.forEach((importAs) => { this.importAs.set(importAs.symbol, importAs.importAs); });
135125
}

0 commit comments

Comments
 (0)