Skip to content

Prism.languages['markup-templating'] is undefined #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guoyunhe opened this issue May 16, 2022 · 5 comments · Fixed by #153
Closed

Prism.languages['markup-templating'] is undefined #152

guoyunhe opened this issue May 16, 2022 · 5 comments · Fixed by #153

Comments

@guoyunhe
Copy link

After update to 1.3.2 today, it always throws error:

image

image

Debugging found that Prism.languages['markup-templating'] is undefined.

I believe it is introduced by #151

CC @jpdriver

@cndlhvn
Copy link

cndlhvn commented May 16, 2022

me too

@Josh-Cena
Copy link

Yes, this is happening with Docusaurus as well. facebook/docusaurus#7429

@maoxiaoke
Copy link

+1

@jpdriver
Copy link
Contributor

jpdriver commented May 16, 2022

sorry all!

with the logic introduced in #151 we now account for optional dependencies of each language. however in the course of working on this, i noticed that these changes added a bunch of new grammars that weren't there before.

i thought it would be a good idea to add a restriction so that we restrict it to the same set of grammars (based on includedLangs) as previous versions -- and markup-templating fell into this trap as it wasn't listed in our includedLangs 🤦🏻‍♂️

many thanks for the quick report!

@Josh-Cena
Copy link

I can confirm 1.3.3 works and the Markdown front matter highlighting is properly applied without hacks. Thanks for the swift response @jpdriver and the nice work in #151!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants