Nice!!

Author: cclauss

bit_manipulation/binary_or_operator.py

@@ -1,45 +1,48 @@
-"""
-https://www.tutorialspoint.com/python3/bitwise_operators_example.htm
-This function takes in 2 integer, convert them to binary and returns a binary
-in str format that is the result of an Binary OR operation from the 2 integer
-input.
+# https://www.tutorialspoint.com/python3/bitwise_operators_example.htm
 
-Returns a binary resulted from 2 integer input in str format
->>> binary_or(25,32)
-'0b111001'
 
->>> binary_or(37,50)
-'0b110111'
-
->>> binary_or(21,30)
-'0b11111'
-
->>> binary_or(58,73)
-'0b1111011'
-"""
-
-
-def binary_or(a : int, b : int):
-    if isinstance(a, float) or isinstance(b, float):
-        raise TypeError("'Float' object cannot be implemented as an integer")
-    if isinstance(a, str) or isinstance(b, str):
-        raise TypeError("'str' object cannot be implemented as an integer")
-    if a < 0 or b < 0:
-        raise ValueError("the value of both input must be positive")
+def binary_or(a: int, b: int):
     """
-    a_binary and b_binary are the binary of a and b in str format
+    Take in 2 integers, convert them to binary, and return a binary number that is the
+    result of a binary or operation on the integers provided.
+
+    >>> binary_or(25, 32)
+    '0b111001'
+    >>> binary_or(37, 50)
+    '0b110111'
+    >>> binary_or(21, 30)
+    '0b11111'
+    >>> binary_or(58, 73)
+    '0b1111011'
+    >>> binary_or(0, 255)
+    '0b11111111'
+    >>> binary_or(0, 256)
+    '0b100000000'
+    >>> binary_or(0, -1)
+    Traceback (most recent call last):
+        ...
+    ValueError: the value of both input must be positive
+    >>> binary_or(0, 1.1)
+    Traceback (most recent call last):
+        ...
+    TypeError: 'float' object cannot be interpreted as an integer
+    >>> binary_or("0", "1")
+    Traceback (most recent call last):
+        ...
+    TypeError: '<' not supported between instances of 'str' and 'int'
     """
-    a_binary = str(bin(a))[2:]
+    if a < 0 or b < 0:
+        raise ValueError("the value of both input must be positive")
+    a_binary = str(bin(a))[2:]  # remove the leading "0b"
     b_binary = str(bin(b))[2:]
-    binary = []
     max_len = max(len(a_binary), len(b_binary))
-    a_binary = a_binary.zfill(max_len)
-    b_binary = b_binary.zfill(max_len)
-    for char_a, char_b in zip(a_binary, b_binary):
-        binary.append(str(int(char_a == "1" or char_b == "1")))
-    return "0b" + "".join(binary)
+    return "0b" + "".join(
+        str(int("1" in (char_a, char_b)))
+        for char_a, char_b in zip(a_binary.zfill(max_len), b_binary.zfill(max_len))
+    )
 
 
 if __name__ == "__main__":
     import doctest
+
     doctest.testmod()