Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Commit a92297a

Browse files
committed
Fixed some issues from PR review
1 parent b92a144 commit a92297a

File tree

2 files changed

+3
-89
lines changed

2 files changed

+3
-89
lines changed

src/SerialTransceiver.cpp

-61
This file was deleted.

src/SerialTransceiver.h

+3-28
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,3 @@
1-
#ifndef MODEM_SERIAL_TRANSCIEVER_H
2-
#define MODEM_SERIAL_TRANSCIEVER_H
3-
4-
#include <memory>
5-
6-
#include "Firebase.h"
7-
#include "modem/commands.h"
8-
9-
namespace firebase {
10-
namespace modem {
11-
12-
class SerialTransceiver {
13-
public:
14-
void begin(Stream* serial);
15-
void loop();
16-
17-
private:
18-
std::unique_ptr<Command> CreateCommand(const String& name, Firebase* fbase);
19-
20-
std::unique_ptr<Firebase> fbase_;
21-
std::unique_ptr<ArduinoInputStream> in_;
22-
std::unique_ptr<ArduinoOutputStream> out_;
23-
};
24-
25-
} // modem
26-
} // firebase
27-
28-
#endif // MODEM_SERIAL_TRANSCIEVER_H
1+
#include "modem/SerialTransceiver.h"
2+
// Bring them into the base namespace for easier use in arduino ide.
3+
using firebase::modem::SerialTransceiver;

0 commit comments

Comments
 (0)