Fixed some issues from PR review

ed7coyne · ed7coyne · commit 7c2c60cf9c43 · 2016-04-15T14:13:34.000-07:00
Modem design image modified diagram renamed diagram Create design.md Update design.md Updated diagram Update design.md switched diagram back to png Update design.md Update design.md Untested initial command with tests Added gmock/gtest submodules Revert "Added gmock/gtest submodules" This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one. Added googletest submodule import example make file Added *Ptr methods to firebase, get test mostly compiling Broke FirebaseHttpClient out from Firebase to allow greater portability and testability. re check in commands and add input stream Working local command test Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Clean up get test and added failure handling Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n Add base for SerialTransciever. Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working unit tests are all working with new changes Added stream command using simple syntax. Fixes from testing with serial modem Reorganized the library to comply with arduino 1.5+ library standards https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification Fixed some issues from PR review Modem design image modified diagram renamed diagram Create design.md Update design.md Updated diagram Update design.md switched diagram back to png Update design.md Update design.md Untested initial command with tests Added gmock/gtest submodules Revert "Added gmock/gtest submodules" This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one. Added googletest submodule import example make file Added *Ptr methods to firebase, get test mostly compiling Broke FirebaseHttpClient out from Firebase to allow greater portability and testability. re check in commands and add input stream Working local command test Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Clean up get test and added failure handling Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n Add base for SerialTransciever. Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working unit tests are all working with new changes Add modified submodule Added stream command using simple syntax. Fixes from testing with serial modem Reorganized the library to comply with arduino 1.5+ library standards https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification Fixed some issues from PR review re check in commands and add input stream Working local command test Update design.md Update design.md Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n Add base for SerialTransciever. Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working unit tests are all working with new changes Add modified submodule Added stream command using simple syntax. Fixes from testing with serial modem Reorganized the library to comply with arduino 1.5+ library standards https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification Fixed some issues from PR review
diff --git a/examples/FirebaseSerialHost_ESP8266/FirebaseSerialHost_ESP8266.ino b/examples/FirebaseSerialHost_ESP8266/FirebaseSerialHost_ESP8266.ino
@@ -15,8 +15,8 @@
 //
 
 
-// FirebasePush_ESP8266 is a sample that will start our serial transciever
-// listening on a software port and allow debug over the main serial port.
+// A sample that will start our serial transciever listening on a software
+// port and allow debug over the main serial port.
 //
 // A suggested setup for testing this example would be a USB to TTL cable
 // with the green wire connected to pin 5 and the white wire connected to
diff --git a/src/Firebase.h b/src/Firebase.h
@@ -40,6 +40,10 @@ class Firebase {
 
   Firebase(const Firebase&) = delete;
 
+  Firebase(const Firebase&) = delete;
+
+  Firebase(const Firebase&) = delete;
+
   // Fetch auth string back.
   const String& auth();
 
@@ -191,6 +195,6 @@ class FirebaseStream : public FirebaseCall {
 
  private:
   FirebaseError _error;
- };
+};
 
 #endif // firebase_h
diff --git a/src/SerialTransceiver.h b/src/SerialTransceiver.h
@@ -1,28 +1,3 @@
-#ifndef MODEM_SERIAL_TRANSCIEVER_H
-#define MODEM_SERIAL_TRANSCIEVER_H
-
-#include <memory>
-
-#include "Firebase.h"
-#include "modem/commands.h"
-
-namespace firebase {
-namespace modem {
-
-class SerialTransceiver {
- public:
-  void begin(Stream* serial);
-  void loop();
-
- private:
-  std::unique_ptr<Command> CreateCommand(const String& name, Firebase* fbase);
-
-  std::unique_ptr<Firebase> fbase_;
-  std::unique_ptr<ArduinoInputStream> in_;
-  std::unique_ptr<ArduinoOutputStream> out_;
-};
-
-}  // modem
-}  // firebase
-
-#endif // MODEM_SERIAL_TRANSCIEVER_H
+#include "modem/SerialTransceiver.h"
+// Bring them into the base namespace for easier use in arduino ide.
+using firebase::modem::SerialTransceiver;
diff --git a/src/modem/SerialTransceiver.cpp b/src/modem/SerialTransceiver.cpp
diff --git a/src/modem/SerialTransceiver.h b/src/modem/SerialTransceiver.h
@@ -0,0 +1,28 @@
+#ifndef MODEM_SERIAL_TRANSCIEVER_H
+#define MODEM_SERIAL_TRANSCIEVER_H
+
+#include <memory>
+
+#include "Firebase.h"
+#include "modem/commands.h"
+
+namespace firebase {
+namespace modem {
+
+class SerialTransceiver {
+ public:
+  void begin(Stream* serial);
+  void loop();
+
+ private:
+  std::unique_ptr<Command> CreateCommand(const String& name, Firebase* fbase);
+
+  std::unique_ptr<Firebase> fbase_;
+  std::unique_ptr<ArduinoInputStream> in_;
+  std::unique_ptr<ArduinoOutputStream> out_;
+};
+
+}  // modem
+}  // firebase
+
+#endif // MODEM_SERIAL_TRANSCIEVER_H
