fix error empty checks, header files and makefile for modem test

Author: kotl

contrib/src/modem/db/get-command.cpp

@@ -16,7 +16,7 @@ bool GetCommand::execute(const String& command,
   String path = in->readLine();
   String value = fbase().getString(path);
 
-  if (fbase().error() != "") {
+  if (fbase().error().length() == 0) {
     out->print("-FAIL ");
     out->println(fbase().error().c_str());
     return false;

contrib/src/modem/db/push-command.cpp

@@ -19,7 +19,7 @@ bool PushCommand::execute(const String& command,
 
   fbase().pushString(path, data);
 
-  if (fbase().error() != "") {
+  if (fbase().error().length() == 0) {
     out->print("-FAIL ");
     out->println(fbase().error().c_str());
     return false;

contrib/src/modem/db/remove-command.cpp

@@ -16,7 +16,7 @@ bool RemoveCommand::execute(const String& command,
   String path = in->readLine();
   fbase().remove(path);
 
-  if (fbase().error() != "") {
+  if (fbase().error().length() == 0) {
     out->print("-FAIL ");
     out->println(fbase().error().c_str());
     return false;

contrib/src/modem/db/set-command.cpp

@@ -19,7 +19,7 @@ bool SetCommand::execute(const String& command,
 
   fbase().setString(path, data);
 
-  if (fbase().error() != "") {
+  if (fbase().error().length() == 0) {
     out->print("-FAIL ");
     out->println(fbase().error().c_str());
     return false;

contrib/src/modem/db/stream-command.cpp

@@ -16,7 +16,7 @@ bool StreamCommand::execute(const String& command,
   String path = in->readLine().c_str();
   fbase().stream(path);  
 
-  if (fbase().error() != "") {
+  if (fbase().error().length() == 0) {
     out->print("-FAIL ");
     out->println(fbase().error().c_str());
     return false;

contrib/test/modem/Makefile

@@ -130,8 +130,8 @@ arduino_mock_all.a : ArduinoMockAll.o
 
 # Builds shared objects.
 
-Firebase.o : $(FIREBASE_SRC_ROOT)/Firebase.cpp
-	$(CXX) $(CPPFLAGS) $(CXXFLAGS) -c $(FIREBASE_SRC_ROOT)/Firebase.cpp
+Firebase.o : $(FIREBASE_SRC_ROOT)/FirebaseArduino.cpp
+	$(CXX) $(CPPFLAGS) $(CXXFLAGS) -c $(FIREBASE_SRC_ROOT)/FirebaseArduino.cpp
 
 FirebaseHttpClient_dummy.o : $(PROJECT_ROOT)/test/dummies/FirebaseHttpClient_dummy.cpp
 	$(CXX) $(CPPFLAGS) $(CXXFLAGS) -c $(PROJECT_ROOT)/test/dummies/FirebaseHttpClient_dummy.cpp

contrib/test/modem/begin-command_test.cpp

@@ -1,4 +1,4 @@
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "gtest/gtest.h"
 #include "modem/db/commands.h"
 #include "test/modem/mock-input-stream.h"

contrib/test/modem/get-command_test.cpp

@@ -1,4 +1,4 @@
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "gtest/gtest.h"
 #include "modem/db/commands.h"
 #include "test/modem/mock-input-stream.h"

contrib/test/modem/push-command_test.cpp

@@ -1,4 +1,4 @@
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "gtest/gtest.h"
 #include "modem/db/commands.h"
 #include "modem/json_util.h"

contrib/test/modem/remove-command_test.cpp

@@ -2,7 +2,7 @@
 #include "test/modem/mock-output-stream.h"
 #include "test/modem/mock-input-stream.h"
 #include "test/mock-firebase.h"
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "modem/db/commands.h"
 
 namespace firebase {

contrib/test/modem/serial-transceiver_test.cpp

@@ -1,6 +1,6 @@
 #include <vector>
 
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "gtest/gtest.h"
 #include "modem/SerialTransceiver.h"
 

contrib/test/modem/set-command_test.cpp

@@ -1,4 +1,4 @@
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "gtest/gtest.h"
 #include "modem/db/commands.h"
 #include "modem/json_util.h"

contrib/test/modem/stream-command_test.cpp

@@ -1,4 +1,4 @@
-#include "Firebase.h"
+#include "FirebaseArduino.h"
 #include "gtest/gtest.h"
 #include "modem/db/commands.h"
 #include "test/modem/mock-input-stream.h"