Skip to content

Commit a13523f

Browse files
committed
Add failing test for #236 (in 2.11 in case we can add fix there)
1 parent b38679f commit a13523f

File tree

5 files changed

+22
-10
lines changed

5 files changed

+22
-10
lines changed

avro/src/test/java/com/fasterxml/jackson/dataformat/avro/AmbiguousUnionWriteTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
package com.fasterxml.jackson.dataformat.avro;
22

3-
import com.fasterxml.jackson.dataformat.avro.AvroMapper;
4-
import com.fasterxml.jackson.dataformat.avro.AvroSchema;
5-
63
/* 23-Aug-2017, tatu: There was some confusion on whether potential ambiguity
74
* might be problematic (compared to actual one) -- this test verifies
85
* it should not be.

cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/CBORTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public abstract class CBORTestBase
2323
protected CBORParser cborParser(ByteArrayOutputStream bytes) throws IOException {
2424
return cborParser(bytes.toByteArray());
2525
}
26-
26+
2727
protected CBORParser cborParser(byte[] input) throws IOException {
2828
return cborParser(cborFactory(), input);
2929
}
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package com.fasterxml.jackson.dataformat.cbor.failing;
2+
3+
import com.fasterxml.jackson.core.JsonToken;
4+
import com.fasterxml.jackson.dataformat.cbor.CBORParser;
5+
import com.fasterxml.jackson.dataformat.cbor.CBORTestBase;
6+
7+
public class ParseInvalidUTF8String236Test extends CBORTestBase
8+
{
9+
// [dataformats-binary#236]: Ends with the first byte of alleged 2-byte
10+
// UTF-8 character; parser trying to access second byte beyond end.
11+
public void testArrayIssue236() throws Exception
12+
{
13+
final byte[] input = {0x66, (byte) 0xef, 0x7d, 0x7d, 0xa, 0x2d, (byte) 0xda};
14+
try (CBORParser p = cborParser(input)) {
15+
assertToken(JsonToken.VALUE_STRING, p.nextToken());
16+
assertEquals("foobar", p.getText());
17+
assertNull(p.nextToken());
18+
}
19+
}
20+
}

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/DataBindRoundtripTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@
3232
import com.fasterxml.jackson.annotation.JsonCreator;
3333
import com.fasterxml.jackson.annotation.JsonProperty;
3434
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
35-
import com.fasterxml.jackson.dataformat.ion.EnumAsIonSymbolSerializer;
36-
import com.fasterxml.jackson.dataformat.ion.IonSymbolSerializer;
37-
import com.fasterxml.jackson.dataformat.ion.IonObjectMapper;
3835

3936
import com.amazon.ion.IonStruct;
4037
import com.amazon.ion.IonSystem;

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/BaseTestForSmile.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@
99
import org.junit.Assert;
1010

1111
import com.fasterxml.jackson.core.*;
12-
import com.fasterxml.jackson.dataformat.smile.SmileFactory;
13-
import com.fasterxml.jackson.dataformat.smile.SmileGenerator;
14-
import com.fasterxml.jackson.dataformat.smile.SmileParser;
12+
1513
import com.fasterxml.jackson.dataformat.smile.databind.SmileMapper;
1614

1715
public abstract class BaseTestForSmile

0 commit comments

Comments
 (0)