[skip ci] Minor changes

Signed-off-by: Fabian Haase <[email protected]>

Author: FHaase

scripts/tests/test_validate_docstrings.py

@@ -584,24 +584,15 @@ def prefix_pandas(self):
 
 class BadExamples(object):
 
-    def numpy_imported(self):
+    def unused_import(self):
         """
         Examples
         --------
-        >>> import numpy as np
+        >>> import pandas as pdf
         >>> df = pd.DataFrame(np.ones((3, 3)), columns=('a', 'b', 'c'))
         """
         pass
 
-    def pandas_imported(self):
-        """
-        Examples
-        --------
-        >>> import pandas as pd
-        >>> s = pd.Series(['Antelope', 'Lion', 'Zebra', np.nan])
-        """
-        pass
-
     def missing_whitespace_around_arithmetic_operator(self):
         """
         Examples
@@ -750,16 +741,12 @@ def test_bad_generic_functions(self, func):
          ('pandas.Series.rename in `See Also` section '
           'does not need `pandas` prefix',)),
         # Examples tests
-        ('BadExamples', 'numpy_imported',
-         ('F811 It\'s assumed that pandas and numpy'
-          ' are imported as pd or np',)),
-        ('BadExamples', 'pandas_imported',
-         ('F811 It\'s assumed that pandas and numpy'
-          ' are imported as pd or np',)),
+        ('BadExamples', 'unused_import',
+         ('1 F401 \'pandas as pdf\' imported but unused',)),
         ('BadExamples', 'indentation_is_not_a_multiple_of_four',
-         ('E111 indentation is not a multiple of four',)),
+         ('1 E111 indentation is not a multiple of four',)),
         ('BadExamples', 'missing_whitespace_around_arithmetic_operator',
-         ('E226 missing whitespace around arithmetic operator',)),
+         ('1 E226 missing whitespace around arithmetic operator',)),
         ('BadExamples', 'missing_whitespace_after_comma',
          ('3 E231 missing whitespace after \',\'',)),
     ])

scripts/validate_docstrings.py

@@ -13,7 +13,6 @@
     $ ./validate_docstrings.py
     $ ./validate_docstrings.py pandas.DataFrame.head
 """
-import contextlib
 import os
 import sys
 import json
@@ -173,7 +172,7 @@ def _load_obj(name):
     @staticmethod
     def _to_original_callable(obj):
         """
-        Find the Python object that contains the source code ot the object.
+        Find the Python object that contains the source code of the object.
 
         This is useful to find the place in the source code (file and line
         number) where a docstring is defined. It does not currently work for
@@ -336,32 +335,25 @@ def parameter_mismatches(self):
 
         return errs
 
-    @contextlib.contextmanager
-    def _write_examples_code_to_temp_file(self):
-        """
-        Generate file with source code from examples section.
-        """
-        content = ''.join(('import numpy as np; '
-                           'import pandas as pd  # noqa: F401,E702\n',
+    def validate_pep8(self):
+        if not self.examples:
+            return
+
+        content = ''.join(('import numpy as np  # noqa: F401\n',
+                           'import pandas as pd  # noqa: F401\n',
                            *self.examples_source_code))
+
+        application = flake8.main.application.Application()
+        application.initialize(["--quiet"])
+
         with tempfile.NamedTemporaryFile(mode='w') as file:
             file.write(content)
             file.flush()
-            yield file
+            application.run_checks([file.name])
 
-    def validate_pep8(self):
-        if self.examples:
-            with self._write_examples_code_to_temp_file() as file:
-                application = flake8.main.application.Application()
-                application.initialize(["--quiet"])
-                application.run_checks([file.name])
-                application.report()
-
-            for statistic in application.guide.stats.statistics_for(''):
-                if statistic.message.endswith('from line 1'):
-                    statistic.message = "It's assumed that pandas and numpy" \
-                                        " are imported as pd or np"
-                yield statistic
+        application.report()
+
+        yield from application.guide.stats.statistics_for('')
 
     @property
     def correct_parameters(self):