include PSScriptAnalyzer rule PSReviewUnusedParameter

FH-Inway · FH-Inway · commit 937bf59aeccd · 2024-05-02T13:16:59.000+02:00
According to PowerShell/PSScriptAnalyzer#1472 (comment), this rule is now evaluated with less false positive.
diff --git a/d365fo.tools/tests/general/PSScriptAnalyzer.Tests.ps1 b/d365fo.tools/tests/general/PSScriptAnalyzer.Tests.ps1
@@ -18,7 +18,7 @@ Describe 'Invoking PSScriptAnalyzer against commandbase' {
 	foreach ($file in $commandFiles)
 	{
 		Context "Analyzing $($file.BaseName)" {
-			$analysis = Invoke-ScriptAnalyzer -Path $file.FullName -ExcludeRule PSAvoidTrailingWhitespace, PSShouldProcess, PSReviewUnusedParameter
+			$analysis = Invoke-ScriptAnalyzer -Path $file.FullName -ExcludeRule PSAvoidTrailingWhitespace, PSShouldProcess
 			
 			forEach ($rule in $scriptAnalyzerRules)
 			{

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ Describe 'Invoking PSScriptAnalyzer against commandbase' {`
`18`	`18`	`foreach ($file in $commandFiles)`
`19`	`19`	`{`
`20`	`20`	`Context "Analyzing $($file.BaseName)" {`
`21`		`- $analysis = Invoke-ScriptAnalyzer -Path $file.FullName -ExcludeRule PSAvoidTrailingWhitespace, PSShouldProcess, PSReviewUnusedParameter`
	`21`	`+ $analysis = Invoke-ScriptAnalyzer -Path $file.FullName -ExcludeRule PSAvoidTrailingWhitespace, PSShouldProcess`
`22`	`22`
`23`	`23`	`forEach ($rule in $scriptAnalyzerRules)`
`24`	`24`	`{`