Skip to content

Commit d5e48b8

Browse files
authored
Fix closing stream on retval errors (#149)
Signed-off-by: Ondrej Fabry <[email protected]>
1 parent 6431e5f commit d5e48b8

File tree

12 files changed

+13
-0
lines changed

12 files changed

+13
-0
lines changed

Diff for: binapi/graph/graph_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/interface/interface_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/ip/ip_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/ipfix_export/ipfix_export_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/lcp/lcp_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/map/map_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/mss_clamp/mss_clamp_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/nat44_ed/nat44_ed_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/nat44_ei/nat44_ei_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/pnat/pnat_rpc.ba.go

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapi/tracedump/tracedump_rpc.ba.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: binapigen/generate_rpc.go

+1
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ func genService(g *GenFile, svc *Service) {
170170
if msgReply != msgControlPingReply {
171171
if retvalField := getRetvalField(msgReply); retvalField != nil {
172172
g.P("if err := ", retvalFieldToErr(g, "m", retvalField), "; err != nil {")
173+
g.P(" c.Stream.Close()")
173174
if msgReply != msgControlPingReply {
174175
g.P(" return nil, m, err")
175176
} else {

0 commit comments

Comments
 (0)