Fix typeanalysis recusion bug and noarg gep (rust-lang#784)

* Fix typeanalysis recusion bug and noarg gep

* Update TypeAnalysis.cpp

Author: wsmoses

enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp

@@ -476,7 +476,7 @@ void getConstantAnalysis(Constant *Val, TypeAnalyzer &TA,
     }
     if (!isa<StructType>(GV->getValueType()) ||
         !cast<StructType>(GV->getValueType())->isOpaque()) {
-      auto globalSize = DL.getTypeSizeInBits(GV->getValueType()) / 8;
+      auto globalSize = (DL.getTypeSizeInBits(GV->getValueType()) + 7) / 8;
       // Since halfs are 16bit (2 byte) and pointers are >=32bit (4 byte) any
       // Single byte object must be integral
       if (globalSize == 1) {
@@ -679,7 +679,7 @@ void TypeAnalyzer::updateAnalysis(Value *Val, TypeTree Data, Value *Origin) {
 
     if (auto GV = dyn_cast<GlobalVariable>(Val)) {
       if (GV->getValueType()->isSized()) {
-        auto Size = DL.getTypeSizeInBits(GV->getValueType()) / 8;
+        auto Size = (DL.getTypeSizeInBits(GV->getValueType()) + 7) / 8;
         Data = analysis[Val].Lookup(Size, DL).Only(-1);
         Data.insert({-1}, BaseType::Pointer);
         analysis[Val] = Data;
@@ -1392,6 +1392,14 @@ void TypeAnalyzer::visitGetElementPtrInst(GetElementPtrInst &gep) {
     }
   }
 
+  if (gep.indices().begin() == gep.indices().end()) {
+    if (direction & DOWN)
+      updateAnalysis(&gep, getAnalysis(gep.getPointerOperand()), &gep);
+    if (direction & UP)
+      updateAnalysis(gep.getPointerOperand(), getAnalysis(&gep), &gep);
+    return;
+  }
+
   auto &DL = fntypeinfo.Function->getParent()->getDataLayout();
 
   auto pointerAnalysis = getAnalysis(gep.getPointerOperand());

enzyme/test/TypeAnalysis/infglobal.ll

@@ -0,0 +1,26 @@
+; RUN: %opt < %s %loadEnzyme -print-type-analysis -type-analysis-func=mainloop -o /dev/null | FileCheck %s
+
+@timeron = internal unnamed_addr global i1 false, align 4
+
+define void @mainloop() {
+entry:
+  %a3 = load i1, i1* @timeron, align 4
+  %c3 = load i1, i1* @timeron, align 4
+  br i1 %a3, label %a4, label %a5
+
+a4:
+  br label %a5
+
+a5:
+  ret void
+}
+
+; CHECK: mainloop - {} |
+; CHECK-NEXT: entry
+; CHECK-NEXT:   %a3 = load i1, i1* @timeron, align 4: {[-1]:Integer}
+; CHECK-NEXT:   %c3 = load i1, i1* @timeron, align 4: {[-1]:Integer}
+; CHECK-NEXT:   br i1 %a3, label %a4, label %a5: {}
+; CHECK-NEXT: a4
+; CHECK-NEXT:   br label %a5: {}
+; CHECK-NEXT: a5
+; CHECK-NEXT:   ret void: {}

enzyme/test/TypeAnalysis/infglobal2.ll

@@ -0,0 +1,20 @@
+; RUN: %opt < %s %loadEnzyme -print-type-analysis -type-analysis-func=mainloop -o /dev/null | FileCheck %s
+
+@timeron = internal unnamed_addr global float 0.000000e+00, align 4
+
+define void @mainloop() {
+entry:
+  %a3 = load float, float* @timeron, align 4
+  %c3 = load float, float* @timeron, align 4
+  %d = fadd float %a3, %c3
+  %r = load float, float* @timeron, align 4
+  ret void
+}
+
+; CHECK: mainloop - {} |
+; CHECK-NEXT: entry
+; CHECK-NEXT:   %a3 = load float, float* @timeron, align 4: {[-1]:Float@float}
+; CHECK-NEXT:   %c3 = load float, float* @timeron, align 4: {[-1]:Float@float}
+; CHECK-NEXT:   %d = fadd float %a3, %c3: {[-1]:Float@float}
+; CHECK-NEXT:   %r = load float, float* @timeron, align 4: {[-1]:Float@float}
+; CHECK-NEXT:   ret void: {}

enzyme/test/TypeAnalysis/noarggep.ll

@@ -0,0 +1,13 @@
+; RUN: %opt < %s %loadEnzyme -print-type-analysis -type-analysis-func=square -o /dev/null | FileCheck %s
+
+define internal void @square(double* %in) {
+entry:
+  %out = getelementptr inbounds double, double* %in
+  ret void
+}
+
+; CHECK: square - {} |{[-1]:Pointer, [-1,-1]:Float@double}:{} 
+; CHECK-NEXT: double* %in: {[-1]:Pointer, [-1,-1]:Float@double}
+; CHECK-NEXT: entry
+; CHECK-NEXT:   %out = getelementptr inbounds double, double* %in: {[-1]:Pointer, [-1,-1]:Float@double}
+; CHECK-NEXT:   ret void: {}