Skip to content

Commit 8f51620

Browse files
authored
Revert "Make numeric literal underscore test dialect agnostic (apache#1685)"
This reverts commit bccac2c.
1 parent 5e0691d commit 8f51620

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

tests/sqlparser_clickhouse.rs

+15
Original file line numberDiff line numberDiff line change
@@ -1649,6 +1649,21 @@ fn parse_table_sample() {
16491649
clickhouse().verified_stmt("SELECT * FROM tbl SAMPLE 1 / 10 OFFSET 1 / 2");
16501650
}
16511651

1652+
#[test]
1653+
fn parse_numbers_with_underscore() {
1654+
let canonical = if cfg!(feature = "bigdecimal") {
1655+
"SELECT 10000"
1656+
} else {
1657+
"SELECT 10_000"
1658+
};
1659+
let select = clickhouse().verified_only_select_with_canonical("SELECT 10_000", canonical);
1660+
1661+
assert_eq!(
1662+
select.projection,
1663+
vec![SelectItem::UnnamedExpr(Expr::Value(number("10_000")))]
1664+
)
1665+
}
1666+
16521667
fn clickhouse() -> TestedDialects {
16531668
TestedDialects::new(vec![Box::new(ClickHouseDialect {})])
16541669
}

tests/sqlparser_common.rs

-18
Original file line numberDiff line numberDiff line change
@@ -55,24 +55,6 @@ use sqlparser::ast::Expr::{Identifier, UnaryOp};
5555
use sqlparser::ast::Value::Number;
5656
use sqlparser::test_utils::all_dialects_except;
5757

58-
#[test]
59-
fn parse_numeric_literal_underscore() {
60-
let dialects = all_dialects_where(|d| d.supports_numeric_literal_underscores());
61-
62-
let canonical = if cfg!(feature = "bigdecimal") {
63-
"SELECT 10000"
64-
} else {
65-
"SELECT 10_000"
66-
};
67-
68-
let select = dialects.verified_only_select_with_canonical("SELECT 10_000", canonical);
69-
70-
assert_eq!(
71-
select.projection,
72-
vec![UnnamedExpr(Expr::Value(number("10_000")))]
73-
);
74-
}
75-
7658
#[test]
7759
fn parse_insert_values() {
7860
let row = vec![

0 commit comments

Comments
 (0)