Dum brute force conversion of all types.

However, StringIO really is ByteIO in most cases, and py2.7 should
run but doesn't.
This should be made work first.

Author: Byron

Diff for: git/cmd.py

@@ -19,7 +19,7 @@
     stream_copy
 )
 from .exc import GitCommandError
-
+from git.compat import text_type
 
 execute_kwargs = ('istream', 'with_keep_cwd', 'with_extended_output',
                   'with_exceptions', 'as_process',
@@ -435,15 +435,15 @@ def transform_kwargs(self, split_single_char_options=False, **kwargs):
     @classmethod
     def __unpack_args(cls, arg_list):
         if not isinstance(arg_list, (list, tuple)):
-            if isinstance(arg_list, unicode):
+            if isinstance(arg_list, text_type):
                 return [arg_list.encode('utf-8')]
             return [str(arg_list)]
 
         outlist = list()
         for arg in arg_list:
             if isinstance(arg_list, (list, tuple)):
                 outlist.extend(cls.__unpack_args(arg))
-            elif isinstance(arg_list, unicode):
+            elif isinstance(arg_list, text_type):
                 outlist.append(arg_list.encode('utf-8'))
             # END recursion
             else:

Diff for: git/compat.py

@@ -5,15 +5,22 @@
 # This module is part of GitPython and is released under
 # the BSD License: http://www.opensource.org/licenses/bsd-license.php
 """utilities to help provide compatibility with python 3"""
+# flake8: noqa
 
-from gitdb.utils.compat import (  # noqa
+from gitdb.utils.compat import (
     PY3,
     xrange,
     MAXSIZE,
     izip,
 )
 
-from gitdb.utils.encoding import (   # noqa
+from gitdb.utils.encoding import (
     string_types,
     text_type
 )
+
+if PY3:
+    import io
+    FileType = io.IOBase
+else:
+    FileType = file

Diff for: git/config.py

@@ -17,6 +17,10 @@
 
 from git.odict import OrderedDict
 from git.util import LockFile
+from git.compat import (
+    string_types,
+    FileType
+)
 
 __all__ = ('GitConfigParser', 'SectionConstraint')
 
@@ -175,7 +179,7 @@ def __init__(self, file_or_files, read_only=True):
                     "Write-ConfigParsers can operate on a single file only, multiple files have been passed")
             # END single file check
 
-            if not isinstance(file_or_files, basestring):
+            if not isinstance(file_or_files, string_types):
                 file_or_files = file_or_files.name
             # END get filename from handle/stream
             # initialize lock base - we want to write
@@ -333,7 +337,7 @@ def write(self):
         close_fp = False
 
         # we have a physical file on disk, so get a lock
-        if isinstance(fp, (basestring, file)):
+        if isinstance(fp, string_types + (FileType, )):
             self._lock._obtain_lock()
         # END get lock for physical files
 
@@ -391,7 +395,7 @@ def get_value(self, section, option, default=None):
                 return default
             raise
 
-        types = (long, float)
+        types = (int, float)
         for numtype in types:
             try:
                 val = numtype(valuestr)
@@ -412,7 +416,7 @@ def get_value(self, section, option, default=None):
         if vl == 'true':
             return True
 
-        if not isinstance(valuestr, basestring):
+        if not isinstance(valuestr, string_types):
             raise TypeError("Invalid value type: only int, long, float and str are allowed", valuestr)
 
         return valuestr

Diff for: git/index/base.py

@@ -39,7 +39,11 @@
 )
 
 from git.objects.util import Serializable
-from git.compat import izip
+from git.compat import (
+    izip,
+    xrange,
+    string_types,
+)
 
 from git.util import (
     LazyMixin,
@@ -541,7 +545,7 @@ def _preprocess_add_items(self, items):
         entries = list()
 
         for item in items:
-            if isinstance(item, basestring):
+            if isinstance(item, string_types):
                 paths.append(self._to_relative_path(item))
             elif isinstance(item, (Blob, Submodule)):
                 entries.append(BaseIndexEntry.from_blob(item))
@@ -752,7 +756,7 @@ def _items_to_rela_paths(self, items):
         for item in items:
             if isinstance(item, (BaseIndexEntry, (Blob, Submodule))):
                 paths.append(self._to_relative_path(item.path))
-            elif isinstance(item, basestring):
+            elif isinstance(item, string_types):
                 paths.append(self._to_relative_path(item))
             else:
                 raise TypeError("Invalid item type: %r" % item)
@@ -1004,7 +1008,7 @@ def handle_stderr(proc, iter_checked_out_files):
             handle_stderr(proc, rval_iter)
             return rval_iter
         else:
-            if isinstance(paths, basestring):
+            if isinstance(paths, string_types):
                 paths = [paths]
 
             # make sure we have our entries loaded before we start checkout_index
@@ -1140,7 +1144,7 @@ def diff(self, other=diff.Diffable.Index, paths=None, create_patch=False, **kwar
         # index against anything but None is a reverse diff with the respective
         # item. Handle existing -R flags properly. Transform strings to the object
         # so that we can call diff on it
-        if isinstance(other, basestring):
+        if isinstance(other, string_types):
             other = self.repo.rev_parse(other)
         # END object conversion
 

Diff for: git/objects/commit.py

@@ -23,6 +23,7 @@
     altz_to_utctz_str,
     parse_actor_and_date
 )
+from git.compat import text_type
 
 from time import (
     time,
@@ -378,7 +379,7 @@ def _serialize(self, stream):
 
         a = self.author
         aname = a.name
-        if isinstance(aname, unicode):
+        if isinstance(aname, text_type):
             aname = aname.encode(self.encoding)
         # END handle unicode in name
 
@@ -390,7 +391,7 @@ def _serialize(self, stream):
 
         # encode committer
         aname = c.name
-        if isinstance(aname, unicode):
+        if isinstance(aname, text_type):
             aname = aname.encode(self.encoding)
         # END handle unicode in name
         write(fmt % ("committer", aname, c.email,
@@ -408,7 +409,7 @@ def _serialize(self, stream):
         write("\n")
 
         # write plain bytes, be sure its encoded according to our encoding
-        if isinstance(self.message, unicode):
+        if isinstance(self.message, text_type):
             write(self.message.encode(self.encoding))
         else:
             write(self.message)

Diff for: git/objects/fun.py

@@ -1,5 +1,9 @@
 """Module with functions which are supposed to be as fast as possible"""
 from stat import S_ISDIR
+from git.compat import (
+    xrange,
+    text_type
+)
 
 __all__ = ('tree_to_stream', 'tree_entries_from_data', 'traverse_trees_recursive',
            'traverse_tree_recursive')
@@ -28,7 +32,7 @@ def tree_to_stream(entries, write):
         # hence we must convert to an utf8 string for it to work properly.
         # According to my tests, this is exactly what git does, that is it just
         # takes the input literally, which appears to be utf8 on linux.
-        if isinstance(name, unicode):
+        if isinstance(name, text_type):
             name = name.encode("utf8")
         write("%s %s\0%s" % (mode_str, name, binsha))
     # END for each item

Diff for: git/objects/submodule/base.py

@@ -22,6 +22,7 @@
     InvalidGitRepositoryError,
     NoSuchPathError
 )
+from git.compat import string_types
 
 import stat
 import git
@@ -93,7 +94,7 @@ def __init__(self, repo, binsha, mode=None, path=None, name=None, parent_commit=
         if url is not None:
             self._url = url
         if branch_path is not None:
-            assert isinstance(branch_path, basestring)
+            assert isinstance(branch_path, string_types)
             self._branch_path = branch_path
         if name is not None:
             self._name = name

Diff for: git/objects/tree.py

@@ -11,6 +11,7 @@
 from .base import IndexObject
 from .blob import Blob
 from .submodule.base import Submodule
+from git.compat import string_types
 
 from .fun import (
     tree_entries_from_data,
@@ -232,7 +233,7 @@ def __getitem__(self, item):
             info = self._cache[item]
             return self._map_id_to_type[info[1] >> 12](self.repo, info[0], info[1], join_path(self.path, info[2]))
 
-        if isinstance(item, basestring):
+        if isinstance(item, string_types):
             # compatability
             return self.__div__(item)
         # END index is basestring

Diff for: git/refs/log.py

@@ -17,6 +17,10 @@
     Serializable,
     altz_to_utctz_str,
 )
+from git.compat import (
+    xrange,
+    string_types
+)
 
 import time
 import re
@@ -170,7 +174,7 @@ def iter_entries(cls, stream):
         :param stream: file-like object containing the revlog in its native format
             or basestring instance pointing to a file to read"""
         new_entry = RefLogEntry.from_line
-        if isinstance(stream, basestring):
+        if isinstance(stream, string_types):
             stream = file_contents_ro_filepath(stream)
         # END handle stream type
         while True:

Diff for: git/refs/symbolic.py

@@ -19,6 +19,7 @@
     hex_to_bin,
     LockedFD
 )
+from git.compat import string_types
 
 from .log import RefLog
 
@@ -274,7 +275,7 @@ def set_reference(self, ref, logmsg=None):
         elif isinstance(ref, Object):
             obj = ref
             write_value = ref.hexsha
-        elif isinstance(ref, basestring):
+        elif isinstance(ref, string_types):
             try:
                 obj = self.repo.rev_parse(ref + "^{}")    # optionally deref tags
                 write_value = obj.hexsha

Diff for: git/repo/base.py

@@ -47,6 +47,7 @@
     read_gitfile,
     touch,
 )
+from git.compat import text_type
 
 import os
 import sys
@@ -176,11 +177,11 @@ def __hash__(self):
     # Description property
     def _get_description(self):
         filename = join(self.git_dir, 'description')
-        return file(filename).read().rstrip()
+        return open(filename).read().rstrip()
 
     def _set_description(self, descr):
         filename = join(self.git_dir, 'description')
-        file(filename, 'w').write(descr + '\n')
+        open(filename, 'w').write(descr + '\n')
 
     description = property(_get_description, _set_description,
                            doc="the project's description")
@@ -389,7 +390,7 @@ def commit(self, rev=None):
         if rev is None:
             return self.head.commit
         else:
-            return self.rev_parse(unicode(rev) + "^0")
+            return self.rev_parse(text_type(rev) + "^0")
 
     def iter_trees(self, *args, **kwargs):
         """:return: Iterator yielding Tree objects
@@ -412,7 +413,7 @@ def tree(self, rev=None):
         if rev is None:
             return self.head.commit.tree
         else:
-            return self.rev_parse(unicode(rev) + "^{tree}")
+            return self.rev_parse(text_type(rev) + "^{tree}")
 
     def iter_commits(self, rev=None, paths='', **kwargs):
         """A list of Commit objects representing the history of a given ref/commit

Diff for: git/repo/fun.py

@@ -13,6 +13,7 @@
     hex_to_bin,
     bin_to_hex
 )
+from git.compat import xrange
 
 
 __all__ = ('rev_parse', 'is_git_dir', 'touch', 'read_gitfile', 'find_git_dir', 'name_to_object',

Diff for: git/test/lib/helper.py

@@ -6,13 +6,15 @@
 from __future__ import print_function
 import os
 import sys
-from git import Repo, Remote, GitCommandError, Git
 from unittest import TestCase
 import time
 import tempfile
 import shutil
 import io
 
+from git import Repo, Remote, GitCommandError, Git
+from git.compat import string_types
+
 GIT_REPO = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))
 
 __all__ = (
@@ -89,7 +91,7 @@ def with_rw_repo(working_tree_ref, bare=False):
     To make working with relative paths easier, the cwd will be set to the working
     dir of the repository.
     """
-    assert isinstance(working_tree_ref, basestring), "Decorator requires ref name for working tree checkout"
+    assert isinstance(working_tree_ref, string_types), "Decorator requires ref name for working tree checkout"
 
     def argument_passer(func):
         def repo_creator(self):
@@ -152,7 +154,7 @@ def case(self, rw_repo, rw_remote_repo)
     See working dir info in with_rw_repo
     :note: We attempt to launch our own invocation of git-daemon, which will be shutdown at the end of the test.
     """
-    assert isinstance(working_tree_ref, basestring), "Decorator requires ref name for working tree checkout"
+    assert isinstance(working_tree_ref, string_types), "Decorator requires ref name for working tree checkout"
 
     def argument_passer(func):
         def remote_repo_creator(self):

Diff for: git/test/performance/test_commit.py

@@ -4,13 +4,16 @@
 # This module is part of GitPython and is released under
 # the BSD License: http://www.opensource.org/licenses/bsd-license.php
 from __future__ import print_function
+from io import StringIO
+from time import time
+import sys
+
 from .lib import TestBigRepoRW
 from git import Commit
 from gitdb import IStream
+from git.compat import xrange
 from git.test.test_commit import assert_commit_serialization
-from io import StringIO
-from time import time
-import sys
+
 
 
 class TestPerformance(TestBigRepoRW):