Skip to content

Commit 21c5f87

Browse files
committed
Don't preinstall dependencies in test_installation
This removes the step in test_installation that did the equivalent of "pip install -r requirements.txt", because installing GitPython is sufficient to install all its required dependencies, and it is more important to test that than to test requirements.txt directly. Removing this causes the test to fail if installing the project doesn't entail installation of the requirements necessary to import the git module or to cause gitdb to be found in a sys.path search.
1 parent b9b6d8c commit 21c5f87

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

Diff for: test/test_installation.py

-10
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,6 @@ def setUp_venv(self, rw_dir):
2323
@with_rw_directory
2424
def test_installation(self, rw_dir):
2525
self.setUp_venv(rw_dir)
26-
result = subprocess.run(
27-
[self.pip, "install", "-r", "requirements.txt"],
28-
stdout=subprocess.PIPE,
29-
cwd=self.sources,
30-
)
31-
self.assertEqual(
32-
0,
33-
result.returncode,
34-
msg=result.stderr or result.stdout or "Can't install requirements",
35-
)
3626
result = subprocess.run(
3727
[self.pip, "install", "."],
3828
stdout=subprocess.PIPE,

0 commit comments

Comments
 (0)