Skip to content

Commit 203da23

Browse files
committed
Add a few FIXMEs re: better use of xfail
1 parent fc02230 commit 203da23

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Diff for: test/test_config.py

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ def test_includes_order(self):
100100
# values must be considered as soon as they get them
101101
assert r_config.get_value("diff", "tool") == "meld"
102102
try:
103+
# FIXME: Split this assertion out somehow and mark it xfail (or fix it).
103104
assert r_config.get_value("sec", "var1") == "value1_main"
104105
except AssertionError as e:
105106
raise SkipTest("Known failure -- included values are not in effect right away") from e

Diff for: test/test_util.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ def setup(self):
8585
"array": [42],
8686
}
8787

88+
# FIXME: Mark only the /proc-prefixing cases xfail, somehow (or fix them).
8889
@pytest.mark.xfail(
8990
reason="Many return paths prefixed /proc/cygdrive instead.",
9091
raises=AssertionError,
@@ -103,7 +104,7 @@ def test_cygpath_ok(self, case):
103104
@skipUnless(sys.platform == "cygwin", "Paths specifically for Cygwin.")
104105
@ddt.data(
105106
(r"./bar", "bar"),
106-
(r".\bar", "bar"),
107+
(r".\bar", "bar"), # FIXME: Mark only this one xfail, somehow (or fix it).
107108
(r"../bar", "../bar"),
108109
(r"..\bar", "../bar"),
109110
(r"../bar/.\foo/../chu", "../bar/chu"),

0 commit comments

Comments
 (0)