Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 36b17ba

Browse files
Basic integration of Crashlytics for iOS... #549 (hardening the metadata-copy-hack)
1 parent 69b5d15 commit 36b17ba

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

demo/app/main-view-model.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,8 @@ export class HelloWorldModel extends Observable {
568568
}
569569

570570
public doGetRemoteConfig(): void {
571+
// TODO downgrade to 3.4 and see if we get logging and alerts.. do this before publishing (the otherwise finished) 5.3.0 version
572+
// .. hmm doesn't look like it... and neither is disabling crash reporting
571573
console.log(">>> doGetRemoteConfig");
572574
firebase.getRemoteConfig({
573575
developerMode: true,

publish/scripts/installer.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -625,9 +625,12 @@ task copyMetadata {
625625
doLast {
626626
copy {
627627
from "$projectDir/src/main/assets/metadata"
628-
def toDir = new File("$projectDir/build/intermediates/assets").listFiles()[0].name
629-
if (toDir != 'debug' && toDir != 'release') {
628+
def toDir = project.hasProperty("release") ? "release" : "debug";
629+
if (new File("$projectDir/build/intermediates/assets").listFiles() != null) {
630+
toDir = new File("$projectDir/build/intermediates/assets").listFiles()[0].name
631+
if (toDir != 'debug' && toDir != 'release') {
630632
toDir += "/release"
633+
}
631634
}
632635
into "$projectDir/build/intermediates/assets/" + toDir + "/metadata"
633636
}

src/package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@
3838
"config": "node scripts/postinstall.js config",
3939
"tsc": "tsc -skipLibCheck",
4040
"plugin.tscwatch": "npm run tsc -- -w",
41-
"package": "cd ../publish && rm -rf ./package && ./pack.sh",
42-
"demo.ios": "npm run preparedemo && cd ../demo && tns platform remove ios && tns run ios",
43-
"demo-ng.ios": "npm run preparedemo-ng && cd ../demo-ng && tns platform remove ios && tns run ios",
44-
"demo.android": "npm run preparedemo && cd ../demo && tns platform remove android && tns run android",
41+
"package": "cd ../publish && rimraf ./package && ./pack.sh",
42+
"demo.ios": "npm run preparedemo && cd ../demo && rimraf platforms/ios && tns run ios",
43+
"demo-ng.ios": "npm run preparedemo-ng && cd ../demo-ng && rimraf platforms/ios && tns run ios",
44+
"demo.android": "npm run preparedemo && cd ../demo && rimraf platforms/android && tns run android",
4545
"demo-ng.android": "npm run preparedemo-ng && cd ../demo-ng && tns run android",
4646
"test": "npm run tslint && npm run tslint.demo && cd ../demo && tns build ios && tns build android",
4747
"test.ios": "cd ../demo && tns test ios --emulator",
@@ -105,6 +105,7 @@
105105
"xcode": "~0.9.0"
106106
},
107107
"devDependencies": {
108+
"rimraf": "^2.6.2",
108109
"tns-core-modules": "~4.0.0",
109110
"tns-platform-declarations": "~4.0.0",
110111
"tslint": "^5.1.0",

src/scripts/postinstall.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3423,9 +3423,12 @@ task copyMetadata {
34233423
doLast {
34243424
copy {
34253425
from "$projectDir/src/main/assets/metadata"
3426-
def toDir = new File("$projectDir/build/intermediates/assets").listFiles()[0].name
3427-
if (toDir != 'debug' && toDir != 'release') {
3426+
def toDir = project.hasProperty("release") ? "release" : "debug";
3427+
if (new File("$projectDir/build/intermediates/assets").listFiles() != null) {
3428+
toDir = new File("$projectDir/build/intermediates/assets").listFiles()[0].name
3429+
if (toDir != 'debug' && toDir != 'release') {
34283430
toDir += "/release"
3431+
}
34293432
}
34303433
into "$projectDir/build/intermediates/assets/" + toDir + "/metadata"
34313434
}

0 commit comments

Comments
 (0)