Skip to content

$qProvider.errorOnUnhandledRejections(false) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yankovsky opened this issue Jun 7, 2017 · 8 comments
Closed

$qProvider.errorOnUnhandledRejections(false) #1

Yankovsky opened this issue Jun 7, 2017 · 8 comments
Assignees

Comments

@Yankovsky
Copy link

Yankovsky commented Jun 7, 2017

Hi! Great lib. Can you explain what is the purpose of this line?

cancellableModule.config(['$qProvider', function($qProvider){
  $qProvider.errorOnUnhandledRejections(false);
}]);
@EPICmynamesBG
Copy link
Owner

@Yankovsky If I remember my debugging correctly, this resolves an error that Angular v1.5.9+ throws when used with ui-router. See this thread for more info.

However, thank you for the note. I'll review that code to see if that is still necessary. 👍

@Yankovsky
Copy link
Author

Yankovsky commented Jun 10, 2017

I am not sure that is it responsibility of this lib to take care of ui-router integration. I want to use your lib but I am afraid of such side effects.

@EPICmynamesBG
Copy link
Owner

@Yankovsky I'm looking into removing that now. As I'm digging in, I remembered it's not a ui-router specific issue, but a general Angular issue. I'm attempting to remove it now, but it could take a while. If you have ideas on how to properly fix this, please feel free to contribute via comments or a PR

@EPICmynamesBG EPICmynamesBG self-assigned this Jun 13, 2017
@EPICmynamesBG
Copy link
Owner

@Yankovsky I believe I've fixed it. If you're willing to checkout the develop branch, it'd be nice to have a tester before pushing the changes to the npm registry

@Yankovsky
Copy link
Author

Thank you! I'll check it out.

@Yankovsky
Copy link
Author

I want to integrate your lib with mine https://github.com/Yankovsky/angular-promise-debounce to create ultimate DebouncedCancellableHttp promises :)

@EPICmynamesBG
Copy link
Owner

@Yankovsky Looks pretty cool. Any report on how those updates worked out for you? If it's good, I'll go ahead and merge master and update npm

@EPICmynamesBG
Copy link
Owner

Merged updates into master and published update to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants