-
Notifications
You must be signed in to change notification settings - Fork 0
$qProvider.errorOnUnhandledRejections(false) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Yankovsky If I remember my debugging correctly, this resolves an error that Angular v1.5.9+ throws when used with ui-router. See this thread for more info. However, thank you for the note. I'll review that code to see if that is still necessary. 👍 |
I am not sure that is it responsibility of this lib to take care of ui-router integration. I want to use your lib but I am afraid of such side effects. |
@Yankovsky I'm looking into removing that now. As I'm digging in, I remembered it's not a ui-router specific issue, but a general Angular issue. I'm attempting to remove it now, but it could take a while. If you have ideas on how to properly fix this, please feel free to contribute via comments or a PR |
@Yankovsky I believe I've fixed it. If you're willing to checkout the develop branch, it'd be nice to have a tester before pushing the changes to the npm registry |
Thank you! I'll check it out. |
I want to integrate your lib with mine https://github.com/Yankovsky/angular-promise-debounce to create ultimate DebouncedCancellableHttp promises :) |
@Yankovsky Looks pretty cool. Any report on how those updates worked out for you? If it's good, I'll go ahead and merge master and update npm |
Merged updates into master and published update to npm |
Uh oh!
There was an error while loading. Please reload this page.
Hi! Great lib. Can you explain what is the purpose of this line?
The text was updated successfully, but these errors were encountered: