Skip to content

Commit 5b1304a

Browse files
committed
Auto merge of rust-lang#103846 - Kobzol:revert-103295-ninja, r=cuviper
Revert "ci: Bring back ninja for dist builders" Reverts rust-lang#103295 because of the perf regression. r? `@cuviper`
2 parents edf0182 + f00d2c9 commit 5b1304a

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/ci/docker/host-x86_64/dist-i686-linux/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ RUN yum upgrade -y && \
2323
libstdc++-devel.x86_64 \
2424
make \
2525
ncurses-devel \
26-
ninja-build \
2726
openssl-devel \
2827
patch \
2928
perl \
@@ -65,6 +64,7 @@ ENV RUST_CONFIGURE_ARGS \
6564
--enable-profiler \
6665
--set target.i686-unknown-linux-gnu.linker=clang \
6766
--build=i686-unknown-linux-gnu \
67+
--set llvm.ninja=false \
6868
--set rust.jemalloc
6969
ENV SCRIPT python3 ../x.py dist --build $HOSTS --host $HOSTS --target $HOSTS
7070
ENV CARGO_TARGET_I686_UNKNOWN_LINUX_GNU_LINKER=clang

src/ci/docker/host-x86_64/dist-x86_64-linux/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ RUN yum upgrade -y && \
2323
libstdc++-devel.x86_64 \
2424
make \
2525
ncurses-devel \
26-
ninja-build \
2726
openssl-devel \
2827
patch \
2928
perl \
@@ -77,6 +76,7 @@ ENV RUST_CONFIGURE_ARGS \
7776
--set target.x86_64-unknown-linux-gnu.ar=/rustroot/bin/llvm-ar \
7877
--set target.x86_64-unknown-linux-gnu.ranlib=/rustroot/bin/llvm-ranlib \
7978
--set llvm.thin-lto=true \
79+
--set llvm.ninja=false \
8080
--set rust.jemalloc \
8181
--set rust.use-lld=true \
8282
--set rust.lto=thin

src/ci/docker/host-x86_64/dist-x86_64-linux/build-clang.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ INC="/rustroot/include:/usr/include"
2525
# disable them. BOLT is used for optimizing LLVM.
2626
hide_output \
2727
cmake ../llvm \
28-
-GNinja \
2928
-DCMAKE_C_COMPILER=/rustroot/bin/gcc \
3029
-DCMAKE_CXX_COMPILER=/rustroot/bin/g++ \
3130
-DCMAKE_BUILD_TYPE=Release \
@@ -40,8 +39,8 @@ hide_output \
4039
-DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt;bolt" \
4140
-DC_INCLUDE_DIRS="$INC"
4241

43-
hide_output ninja
44-
hide_output ninja install
42+
hide_output make -j$(nproc)
43+
hide_output make install
4544

4645
cd ../..
4746
rm -rf llvm-project

0 commit comments

Comments
 (0)