Merge pull request plotly#2034 from moutikabdessabour/ggplotly_color_aes_fix

`ggplotly` not recognizing `color` as aesthetic mapping

Author: moutikabdessabour

R/ggplotly.R

@@ -88,6 +88,7 @@ ggplotly.ggmatrix <- function(p = ggplot2::last_plot(), width = NULL,
                               height = NULL, tooltip = "all", dynamicTicks = FALSE, 
                               layerData = 1, originalData = TRUE, source = "A", ...) {
   dots <- list(...)
+
   # provide a sensible crosstalk if none is already provided (makes ggnostic() work at least)
   if (!crosstalk_key() %in% names(p$data)) {
     p$data[[crosstalk_key()]] <- p$data[[".rownames"]] %||% seq_len(nrow(p$data))

R/layers2traces.R

@@ -23,8 +23,11 @@ layers2traces <- function(data, prestats_data, layout, p) {
     # turn symbol (e.g., ..count..) & call (e.g. calc(count)) mappings into text labels 
     map <- ggfun("make_labels")(map)
 
+
     # filter tooltip aesthetics down to those specified in `tooltip` arg 
     if (!identical(p$tooltip, "all")) {
+      # rectify tooltips, ggplot automatically convert `color` => `colour`
+      p$tooltip[p$tooltip == "color"] <- "colour"
       map <- map[names(map) %in% p$tooltip | map %in% p$tooltip]
     }
 

tests/testthat/test-ggplot-color.R

@@ -0,0 +1,10 @@
+df = data.frame(width = 1:3, height = 1:3, col = letters[1:3])
+test_that("ggplotly automatically converts `color` aes to `colour`", {
+    p <- qplot(width, height, 
+                        data = df, color = col)
+    # color variable is not shown
+    color <- plotly_build(ggplotly(p, tooltip = c("color")))
+    # colour (with u!) variable is shown
+    expect_identical(color$x$data, plotly_build(ggplotly(p, tooltip = c("colour")))$x$data)
+})
+