Simplified checkHasParameter(...) in ParameterBindingParserUnitTests.

Since all the testcases in this class will never qualify as a native query for `StringQuery` we can hardcode the `false`.

Related tickets spring-projects#2409

Author: DiegoKrupitza

src/test/java/org/springframework/data/jpa/repository/query/ParameterBindingParserUnitTests.java

@@ -32,42 +32,41 @@ void identificationOfParameters() {
 
 		SoftAssertions softly = new SoftAssertions();
 
-		checkHasParameter(softly, "select something from x where id = :id", true, "named parameter", false);
-		checkHasParameter(softly, "in the :id middle", true, "middle", false);
-		checkHasParameter(softly, ":id start", true, "beginning", false);
-		checkHasParameter(softly, ":id", true, "alone", false);
-		checkHasParameter(softly, "select something from x where id = :id", true, "named parameter", false);
-		checkHasParameter(softly, ":UPPERCASE", true, "uppercase", false);
-		checkHasParameter(softly, ":lowercase", true, "lowercase", false);
-		checkHasParameter(softly, ":2something", true, "beginning digit", false);
-		checkHasParameter(softly, ":2", true, "only digit", false);
-		checkHasParameter(softly, ":.something", true, "dot", false); // <--
-		checkHasParameter(softly, ":_something", true, "underscore", false);
-		checkHasParameter(softly, ":$something", true, "dollar", false); // <--
-		checkHasParameter(softly, ":\uFE0F", true, "non basic latin emoji", false); // <--
-		checkHasParameter(softly, ":\u4E01", true, "chinese japanese korean", false);
-		checkHasParameter(softly, "select something from x where id = ?1", true, "indexed parameter", false);
+		checkHasParameter(softly, "select something from x where id = :id", true, "named parameter");
+		checkHasParameter(softly, "in the :id middle", true, "middle");
+		checkHasParameter(softly, ":id start", true, "beginning");
+		checkHasParameter(softly, ":id", true, "alone");
+		checkHasParameter(softly, "select something from x where id = :id", true, "named parameter");
+		checkHasParameter(softly, ":UPPERCASE", true, "uppercase");
+		checkHasParameter(softly, ":lowercase", true, "lowercase");
+		checkHasParameter(softly, ":2something", true, "beginning digit");
+		checkHasParameter(softly, ":2", true, "only digit");
+		checkHasParameter(softly, ":.something", true, "dot"); // <--
+		checkHasParameter(softly, ":_something", true, "underscore");
+		checkHasParameter(softly, ":$something", true, "dollar"); // <--
+		checkHasParameter(softly, ":\uFE0F", true, "non basic latin emoji"); // <--
+		checkHasParameter(softly, ":\u4E01", true, "chinese japanese korean");
+		checkHasParameter(softly, "select something from x where id = ?1", true, "indexed parameter");
 
 		// <-- should we accept hash as named parameter start?
-		checkHasParameter(softly, "select something from x where id = #something", false, "hash", false);
+		checkHasParameter(softly, "select something from x where id = #something", false, "hash");
 
-		checkHasParameter(softly, "no bind variable", false, "no bind variable", false);
-		checkHasParameter(softly, ":\u2004whitespace", false, "non basic latin whitespace", false); // <--
-		checkHasParameter(softly, "::", false, "double colon", false);
-		checkHasParameter(softly, ":", false, "end of query", false);
-		checkHasParameter(softly, ":\u0003", false, "non-printable", false);
-		checkHasParameter(softly, ":\u002A", false, "basic latin emoji", false);
-		checkHasParameter(softly, "\\:", false, "escaped colon", false);
-		checkHasParameter(softly, "::id", false, "double colon with identifier", false);
-		checkHasParameter(softly, "\\:id", false, "escaped colon with identifier", false);
+		checkHasParameter(softly, "no bind variable", false, "no bind variable");
+		checkHasParameter(softly, ":\u2004whitespace", false, "non basic latin whitespace"); // <--
+		checkHasParameter(softly, "::", false, "double colon");
+		checkHasParameter(softly, ":", false, "end of query");
+		checkHasParameter(softly, ":\u0003", false, "non-printable");
+		checkHasParameter(softly, ":\u002A", false, "basic latin emoji");
+		checkHasParameter(softly, "\\:", false, "escaped colon");
+		checkHasParameter(softly, "::id", false, "double colon with identifier");
+		checkHasParameter(softly, "\\:id", false, "escaped colon with identifier");
 
 		softly.assertAll();
 	}
 
-	private void checkHasParameter(SoftAssertions softly, String query, boolean containsParameter, String label,
-			boolean nativeQuery) {
+	private void checkHasParameter(SoftAssertions softly, String query, boolean containsParameter, String label) {
 
-		StringQuery stringQuery = new StringQuery(query, nativeQuery);
+		StringQuery stringQuery = new StringQuery(query, false);
 
 		softly.assertThat(stringQuery.getParameterBindings().size()) //
 				.describedAs(String.format("<%s> (%s)", query, label)) //