Remove of useless throws ... in jUnit tests.

A lot of jUnit tests had in the method header a `throws` that is useless. For example `throws Exception` on a method where no exception is thrown. Removing this noice will make the tests more redable.

Original pull request spring-projects#2433

Author: DiegoKrupitza

src/test/java/org/springframework/data/jpa/domain/support/AuditingBeanFactoryPostProcessorUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -59,7 +59,7 @@ DefaultListableBeanFactory getBeanFactory() {
 	}
 
 	@Test
-	void beanConfigurerAspectShouldBeConfiguredAfterPostProcessing() throws Exception {
+	void beanConfigurerAspectShouldBeConfiguredAfterPostProcessing() {
 
 		processor.postProcessBeanFactory(beanFactory);
 

src/test/java/org/springframework/data/jpa/domain/support/AuditingNamespaceUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -39,7 +39,7 @@ String getConfigFile() {
 	}
 
 	@Test
-	void registersBeanDefinitions() throws Exception {
+	void registersBeanDefinitions() {
 
 		BeanDefinition definition = beanFactory.getBeanDefinition(AuditingEntityListener.class.getName());
 		PropertyValue propertyValue = definition.getPropertyValues().getPropertyValue("auditingHandler");

src/test/java/org/springframework/data/jpa/repository/EclipseLinkNamespaceUserRepositoryTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -106,7 +106,7 @@ void bindsNativeQueryResultsToProjectionByName() {}
 	 * Ignores the test. Reconsider once https://bugs.eclipse.org/bugs/show_bug.cgi?id=533240 is fixed.
 	 */
 	@Override
-	void findByEmptyArrayOfIntegers() throws Exception {}
+	void findByEmptyArrayOfIntegers() {}
 
 	/**
 	 * Ignores the test. Reconsider once https://bugs.eclipse.org/bugs/show_bug.cgi?id=533240 is fixed.
@@ -119,13 +119,13 @@ void findByAgeWithEmptyArrayOfIntegersOrFirstName() {
 	 * Ignores the test. Reconsider once https://bugs.eclipse.org/bugs/show_bug.cgi?id=533240 is fixed.
 	 */
 	@Override
-	void findByEmptyCollectionOfIntegers() throws Exception {}
+	void findByEmptyCollectionOfIntegers() {}
 
 	/**
 	 * Ignores the test. Reconsider once https://bugs.eclipse.org/bugs/show_bug.cgi?id=533240 is fixed.
 	 */
 	@Override
-	void findByEmptyCollectionOfStrings() throws Exception {}
+	void findByEmptyCollectionOfStrings() {}
 
 	/**
 	 * Ignores the test for EclipseLink.

src/test/java/org/springframework/data/jpa/repository/EclipseLinkUserRepositoryFinderTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2021 the original author or authors.
+ * Copyright 2011-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,7 +29,7 @@ class EclipseLinkUserRepositoryFinderTests extends UserRepositoryFinderTests {
 
 	@Disabled
 	@Override
-	void executesNotInQueryCorrectly() throws Exception {}
+	void executesNotInQueryCorrectly() {}
 
 	@Disabled
 	@Override

src/test/java/org/springframework/data/jpa/repository/ORMInfrastructureTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -40,10 +40,9 @@ public class ORMInfrastructureTests {
 	/**
 	 * Tests, that the context got initialized and injected correctly.
 	 *
-	 * @throws Exception
 	 */
 	@Test
-	void contextInitialized() throws Exception {
+	void contextInitialized() {
 
 		assertThat(context).isNotNull();
 	}

src/test/java/org/springframework/data/jpa/repository/OpenJpaParentRepositoryIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2013-2021 the original author or authors.
+ * Copyright 2013-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,5 +23,5 @@ class OpenJpaParentRepositoryIntegrationTests extends ParentRepositoryIntegratio
 
 	@Override
 	@Disabled
-	void testWithJoin() throws Exception {}
+	void testWithJoin() {}
 }

src/test/java/org/springframework/data/jpa/repository/OpenJpaUserRepositoryFinderTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2021 the original author or authors.
+ * Copyright 2011-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,5 +29,5 @@ class OpenJpaUserRepositoryFinderTests extends UserRepositoryFinderTests {
 
 	@Disabled
 	@Override
-	void findsByLastnameIgnoringCaseLike() throws Exception {}
+	void findsByLastnameIgnoringCaseLike() {}
 }

src/test/java/org/springframework/data/jpa/repository/ParentRepositoryIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2013-2021 the original author or authors.
+ * Copyright 2013-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -84,7 +84,7 @@ public Predicate toPredicate(Root<Parent> root, CriteriaQuery<?> query, Criteria
 	}
 
 	@Test // DATAJPA-287
-	void testWithJoin() throws Exception {
+	void testWithJoin() {
 		Page<Parent> page = repository.findAll(new Specification<Parent>() {
 			@Override
 			public Predicate toPredicate(Root<Parent> root, CriteriaQuery<?> query, CriteriaBuilder cb) {

src/test/java/org/springframework/data/jpa/repository/RepositoryWithIdClassKeyTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2021 the original author or authors.
+ * Copyright 2016-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -61,7 +61,7 @@ public class RepositoryWithIdClassKeyTests {
 	 *      Specification 2.4.1.3 Derived Identities Example 2</a>
 	 */
 	@Test // DATAJPA-413
-	void shouldSaveAndLoadEntitiesWithDerivedIdentities() throws Exception {
+	void shouldSaveAndLoadEntitiesWithDerivedIdentities() {
 
 		Site site = siteRepository.save(new Site());
 		Item item = itemRepository.save(new Item(123, 456));

src/test/java/org/springframework/data/jpa/repository/RoleRepositoryIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2021 the original author or authors.
+ * Copyright 2011-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -45,15 +45,15 @@ public class RoleRepositoryIntegrationTests {
 	@Autowired RoleRepository repository;
 
 	@Test
-	void createsRole() throws Exception {
+	void createsRole() {
 
 		Role reference = new Role("ADMIN");
 		Role result = repository.save(reference);
 		assertThat(result).isEqualTo(reference);
 	}
 
 	@Test
-	void updatesRole() throws Exception {
+	void updatesRole() {
 
 		Role reference = new Role("ADMIN");
 		Role result = repository.save(reference);

src/test/java/org/springframework/data/jpa/repository/UserRepositoryFinderTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -144,7 +144,7 @@ void executesInKeywordForPageCorrectly() {
 	}
 
 	@Test
-	void executesNotInQueryCorrectly() throws Exception {
+	void executesNotInQueryCorrectly() {
 
 		List<User> result = userRepository.findByFirstnameNotIn(Arrays.asList("Dave", "Carter"));
 
@@ -160,7 +160,7 @@ void findsByLastnameIgnoringCase() {
 	}
 
 	@Test // DATAJPA-92
-	void findsByLastnameIgnoringCaseLike() throws Exception {
+	void findsByLastnameIgnoringCaseLike() {
 
 		List<User> result = userRepository.findByLastnameIgnoringCaseLike("BeAUfo%");
 

src/test/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigDefinitionParserTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,7 +33,7 @@
 class JpaRepositoryConfigDefinitionParserTests {
 
 	@Test
-	void getsTransactionManagerSet() throws Exception {
+	void getsTransactionManagerSet() {
 
 		DefaultListableBeanFactory factory = new DefaultListableBeanFactory();
 		XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(factory);

src/test/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtensionUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2013-2021 the original author or authors.
+ * Copyright 2013-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -92,7 +92,7 @@ void doesNotRegisterProcessorIfAutoRegistered() {
 	}
 
 	@Test // DATAJPA-525
-	void guardsAgainstNullJavaTypesReturnedFromJpaMetamodel() throws Exception {
+	void guardsAgainstNullJavaTypesReturnedFromJpaMetamodel() {
 
 		ApplicationContext context = mock(ApplicationContext.class);
 		EntityManagerFactory emf = mock(EntityManagerFactory.class);

src/test/java/org/springframework/data/jpa/repository/query/Jpa21UtilsUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2015-2021 the original author or authors.
+ * Copyright 2015-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,7 +33,7 @@
 class Jpa21UtilsUnitTests {
 
 	@Test // DATAJPA-696
-	void shouldBuildCorrectSubgraphForJpaEntityGraph() throws Exception {
+	void shouldBuildCorrectSubgraphForJpaEntityGraph() {
 
 		EntityGraph<?> entityGraph = mock(EntityGraph.class);
 		Subgraph<?> subgraph = mock(Subgraph.class);

src/test/java/org/springframework/data/jpa/repository/query/JpaQueryMethodUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -275,7 +275,7 @@ void returnsDefaultCountQueryNameBasedOnConfiguredNamedQueryName() throws Except
 	}
 
 	@Test // DATAJPA-185
-	void rejectsInvalidNamedParameter() throws Exception {
+	void rejectsInvalidNamedParameter() {
 
 		assertThatThrownBy(() -> getQueryMethod(InvalidRepository.class, "findByAnnotatedQuery", String.class))
 				.isInstanceOf(IllegalStateException.class)
@@ -344,8 +344,8 @@ void shouldFindEntityGraphAnnotationOnOverriddenSimpleJpaRepositoryMethodFindOne
 		doReturn(User.class).when(metadata).getDomainType();
 		doReturn(User.class).when(metadata).getReturnedDomainClass((Method) any());
 
-		JpaQueryMethod method = new JpaQueryMethod(JpaRepositoryOverride.class.getMethod("findOne", Integer.class), metadata,
-				factory, extractor);
+		JpaQueryMethod method = new JpaQueryMethod(JpaRepositoryOverride.class.getMethod("findOne", Integer.class),
+				metadata, factory, extractor);
 
 		assertThat(method.getEntityGraph()).isNotNull();
 		assertThat(method.getEntityGraph().getName()).isEqualTo("User.detail");

src/test/java/org/springframework/data/jpa/repository/query/ParameterBinderUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -123,15 +123,15 @@ void bindWorksWithNullForPageable() throws Exception {
 	}
 
 	@Test
-	void usesIndexedParametersIfNoParamAnnotationPresent() throws Exception {
+	void usesIndexedParametersIfNoParamAnnotationPresent() {
 
 		Object[] values = { "foo" };
 		bind(useIndexedParameters, values);
 		verify(query).setParameter(eq(1), any());
 	}
 
 	@Test
-	void usesParameterNameIfAnnotated() throws Exception {
+	void usesParameterNameIfAnnotated() {
 
 		when(query.setParameter(eq("username"), any())).thenReturn(query);
 
@@ -185,8 +185,7 @@ void shouldSetTemporalQueryParameterToTimestamp() throws Exception {
 	}
 
 	@Test // DATAJPA-107
-	void shouldThrowIllegalArgumentExceptionIfIsAnnotatedWithTemporalParamAndParameterTypeIsNotDate()
-			throws Exception {
+	void shouldThrowIllegalArgumentExceptionIfIsAnnotatedWithTemporalParamAndParameterTypeIsNotDate() throws Exception {
 		Method method = SampleRepository.class.getMethod("invalidWithTemporalTypeParameter", String.class);
 
 		assertThatIllegalArgumentException().isThrownBy(() -> new JpaParameters(method));

src/test/java/org/springframework/data/jpa/repository/query/QueryUtilsUnitTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2021 the original author or authors.
+ * Copyright 2008-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -51,7 +51,7 @@ class QueryUtilsUnitTests {
 	private static final String QUERY_WITH_AS = "select u from User as u where u.username = ?";
 
 	@Test
-	void createsCountQueryCorrectly() throws Exception {
+	void createsCountQueryCorrectly() {
 		assertCountQuery(QUERY, COUNT_QUERY);
 	}
 
@@ -64,47 +64,47 @@ void createsCountQueriesCorrectlyForCapitalLetterJPQL() {
 	}
 
 	@Test
-	void createsCountQueryForDistinctQueries() throws Exception {
+	void createsCountQueryForDistinctQueries() {
 
 		assertCountQuery("select distinct u from User u where u.foo = ?",
 				"select count(distinct u) from User u where u.foo = ?");
 	}
 
 	@Test
-	void createsCountQueryForConstructorQueries() throws Exception {
+	void createsCountQueryForConstructorQueries() {
 
 		assertCountQuery("select distinct new User(u.name) from User u where u.foo = ?",
 				"select count(distinct u) from User u where u.foo = ?");
 	}
 
 	@Test
-	void createsCountQueryForJoins() throws Exception {
+	void createsCountQueryForJoins() {
 
 		assertCountQuery("select distinct new User(u.name) from User u left outer join u.roles r WHERE r = ?",
 				"select count(distinct u) from User u left outer join u.roles r WHERE r = ?");
 	}
 
 	@Test
-	void createsCountQueryForQueriesWithSubSelects() throws Exception {
+	void createsCountQueryForQueriesWithSubSelects() {
 
 		assertCountQuery("select u from User u left outer join u.roles r where r in (select r from Role)",
 				"select count(u) from User u left outer join u.roles r where r in (select r from Role)");
 	}
 
 	@Test
-	void createsCountQueryForAliasesCorrectly() throws Exception {
+	void createsCountQueryForAliasesCorrectly() {
 
 		assertCountQuery("select u from User as u", "select count(u) from User as u");
 	}
 
 	@Test
-	void allowsShortJpaSyntax() throws Exception {
+	void allowsShortJpaSyntax() {
 
 		assertCountQuery(SIMPLE_QUERY, COUNT_QUERY);
 	}
 
 	@Test
-	void detectsAliasCorrectly() throws Exception {
+	void detectsAliasCorrectly() {
 
 		assertThat(detectAlias(QUERY)).isEqualTo("u");
 		assertThat(detectAlias(SIMPLE_QUERY)).isEqualTo("u");