fix(performance): correct check for disabling performance

Splaktar · Splaktar · commit 85e581e1f502 · 2020-09-24T22:41:39.000-04:00
- if the app doesn't inject anything and the values are `null`, then we should enable instrumentation and data collection by default Fixes angular#2502
diff --git a/src/performance/performance.ts b/src/performance/performance.ts
@@ -36,10 +36,10 @@ export class AngularFirePerformance {
       tap(perf => perf.registerPerformance && perf.registerPerformance(firebase as any)),
       map(() => zone.runOutsideAngular(() => app.performance())),
       tap(performance => {
-        if (instrumentationEnabled !== true) {
+        if (instrumentationEnabled === false) {
           performance.instrumentationEnabled = false;
         }
-        if (dataCollectionEnabled !== true) {
+        if (dataCollectionEnabled === false) {
           performance.dataCollectionEnabled = false;
         }
       }),

Original file line number	Diff line number	Diff line change
`@@ -36,10 +36,10 @@ export class AngularFirePerformance {`
`36`	`36`	`tap(perf => perf.registerPerformance && perf.registerPerformance(firebase as any)),`
`37`	`37`	`map(() => zone.runOutsideAngular(() => app.performance())),`
`38`	`38`	`tap(performance => {`
`39`		`- if (instrumentationEnabled !== true) {`
	`39`	`+ if (instrumentationEnabled === false) {`
`40`	`40`	`performance.instrumentationEnabled = false;`
`41`	`41`	`}`
`42`		`- if (dataCollectionEnabled !== true) {`
	`42`	`+ if (dataCollectionEnabled === false) {`
`43`	`43`	`performance.dataCollectionEnabled = false;`
`44`	`44`	`}`
`45`	`45`	`}),`