Skip to content

Commit fc33301

Browse files
committed
[hibernate#1838] Remove unused code
This code causes a failure with Quarkus at start up: quarkusio/quarkus#38263 CI still works when I remove it, and a `DeleteOrUpsertOperation` cannot be cast to `OptionalTableUpdate` anyway, so I don't think this code is useful.
1 parent e5ff7de commit fc33301

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

hibernate-reactive-core/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveMergeCoordinatorStandardScopeFactory.java

+1-11
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package org.hibernate.reactive.persister.entity.impl;
77

88

9-
import org.hibernate.dialect.OracleDialect;
109
import org.hibernate.engine.spi.SessionFactoryImplementor;
1110
import org.hibernate.persister.entity.AbstractEntityPersister;
1211
import org.hibernate.persister.entity.mutation.MergeCoordinator;
@@ -22,7 +21,6 @@
2221
import org.hibernate.sql.model.ast.TableMutation;
2322
import org.hibernate.sql.model.internal.MutationOperationGroupFactory;
2423
import org.hibernate.sql.model.internal.OptionalTableUpdate;
25-
import org.hibernate.sql.model.jdbc.DeleteOrUpsertOperation;
2624
import org.hibernate.sql.model.jdbc.OptionalTableUpdateOperation;
2725

2826
public class ReactiveMergeCoordinatorStandardScopeFactory extends MergeCoordinator
@@ -46,6 +44,7 @@ public ReactiveScopedUpdateCoordinator makeScopedCoordinator() {
4644
);
4745
}
4846

47+
// We override the whole method but we just need to plug in our custom createOperation(...) method
4948
@Override
5049
protected MutationOperationGroup createOperationGroup(ValuesAnalysis valuesAnalysis, MutationGroup mutationGroup) {
5150
final int numberOfTableMutations = mutationGroup.getNumberOfTableMutations();
@@ -101,15 +100,6 @@ protected MutationOperation createOperation(ValuesAnalysis valuesAnalysis, Table
101100
factory()
102101
);
103102
}
104-
if ( operation instanceof DeleteOrUpsertOperation
105-
&& factory().getJdbcServices().getDialect() instanceof OracleDialect ) {
106-
OracleDialect dialect = ( (OracleDialect) factory().getJdbcServices().getDialect() );
107-
return dialect.createOptionalTableUpdateOperation(
108-
( (OptionalTableUpdate) operation ).getMutationTarget(),
109-
(OptionalTableUpdate) operation,
110-
factory()
111-
);
112-
}
113103
return operation;
114104
}
115105
}

0 commit comments

Comments
 (0)