[hibernate#950] Remove ProxyConnection class

It's not necessary now that all the openSession methods
return a Uni or CompletionStage

Author: DavideD

hibernate-reactive-core/src/main/java/org/hibernate/reactive/bulk/impl/ReactiveBulkIdStrategy.java

@@ -47,7 +47,6 @@
 import org.hibernate.persister.collection.AbstractCollectionPersister;
 import org.hibernate.persister.entity.Queryable;
 import org.hibernate.reactive.bulk.StatementsWithParameters;
-import org.hibernate.reactive.pool.ReactiveConnection;
 import org.hibernate.reactive.pool.ReactiveConnectionPool;
 import org.hibernate.reactive.pool.impl.Parameters;
 import org.hibernate.reactive.session.ReactiveQueryExecutor;
@@ -130,11 +129,11 @@ public void release(JdbcServices jdbcServices, JdbcConnectionAccess connectionAc
 							false
 					);
 			if ( dropIdTables ) {
-				ReactiveConnection connection = serviceRegistry.getService( ReactiveConnectionPool.class )
-						.getProxyConnection();
-				loop( dropGlobalTemporaryTables, connection::execute )
-						.whenComplete( (v, e) -> connection.close() )
-						.handle( CompletionStages::ignoreErrors )
+				serviceRegistry.getService( ReactiveConnectionPool.class ).getConnection()
+						.thenCompose( connection ->
+							  loop( dropGlobalTemporaryTables, connection::execute )
+									  .whenComplete( (v, e) -> connection.close() )
+									  .handle( CompletionStages::ignoreErrors ) )
 						.toCompletableFuture().join();
 			}
 		}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/ReactiveConnectionPool.java

@@ -47,21 +47,6 @@ public interface ReactiveConnectionPool extends Service {
 	 */
 	CompletionStage<ReactiveConnection> getConnection(String tenantId);
 
-	/**
-	 * Obtain a lazily-initializing reactive connection. The
-	 * actual connection might be made when the returned
-	 * instance if {@link ReactiveConnection} is first used.
-	 */
-	ReactiveConnection getProxyConnection();
-
-	/**
-	 * Obtain a lazily-initializing reactive connection for the
-	 * given tenant id. The actual connection might be made when
-	 * the returned instance if {@link ReactiveConnection} is
-	 * first used.
-	 */
-	ReactiveConnection getProxyConnection(String tenantId);
-
 	/**
 	 * The shutdown of the pool is actually asynchronous but the
 	 * core service registry won't return the {@link CompletionStage}.

hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/ProxyConnection.java

@@ -76,15 +76,4 @@ private CompletionStage<ReactiveConnection> getConnectionFromPool(Pool pool) {
 	private SqlClientConnection newConnection(SqlConnection connection) {
 		return new SqlClientConnection( connection, getPool(), getSqlStatementLogger() );
 	}
-
-	@Override
-	public ReactiveConnection getProxyConnection() {
-		return new ProxyConnection( this );
-	}
-
-	@Override
-	public ReactiveConnection getProxyConnection(String tenantId) {
-		return new ProxyConnection( this, tenantId );
-	}
-
 }