Skip to content

Commit 4a3036c

Browse files
committed
[hibernate#1932] Remove warnings from QueryTest
1 parent 8f940dd commit 4a3036c

File tree

1 file changed

+18
-19
lines changed
  • hibernate-reactive-core/src/test/java/org/hibernate/reactive

1 file changed

+18
-19
lines changed

hibernate-reactive-core/src/test/java/org/hibernate/reactive/QueryTest.java

+18-19
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@
4848
import static org.hibernate.reactive.containers.DatabaseConfiguration.dbType;
4949
import static org.hibernate.reactive.testing.ReactiveAssertions.assertThrown;
5050
import static org.junit.jupiter.api.Assertions.assertEquals;
51+
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
5152
import static org.junit.jupiter.api.Assertions.assertNotNull;
5253
import static org.junit.jupiter.api.Assertions.assertNull;
53-
import static org.junit.jupiter.api.Assertions.assertTrue;
5454

5555
@Timeout(value = 10, timeUnit = MINUTES)
5656
public class QueryTest extends BaseReactiveTest {
@@ -407,10 +407,10 @@ public void testNativeProjectionQuery(VertxTestContext context) {
407407
.thenAccept( books -> {
408408
assertEquals( 3, books.size() );
409409
books.forEach( tuple -> {
410-
assertTrue( tuple instanceof Object[] );
410+
assertInstanceOf( Object[].class, tuple );
411411
assertEquals( 2, tuple.length );
412-
assertTrue( tuple[0] instanceof String );
413-
assertTrue( tuple[1] instanceof String );
412+
assertInstanceOf( String.class, tuple[0] );
413+
assertInstanceOf( String.class, tuple[1] );
414414
} );
415415
} )
416416
.thenCompose( v -> openSession() )
@@ -425,41 +425,40 @@ public void testNativeProjectionQuery(VertxTestContext context) {
425425
.thenAccept( list -> {
426426
Object[] tuple = list.get( 0 );
427427
assertEquals( 3, tuple.length );
428-
assertTrue( tuple[0] instanceof String );
428+
assertInstanceOf( String.class, tuple[0] );
429429
} ) )
430430
.thenCompose( vv -> session
431431
.createNativeQuery( "select title from " + BOOK_TABLE )
432432
.getResultList()
433-
.thenAccept( list -> assertTrue( list.get( 0 ) instanceof String ) )
434-
)
433+
.thenAccept( list -> assertInstanceOf( String.class, list.get( 0 ) ) ) )
435434
.thenCompose( vv -> session
436435
.createNativeQuery( "select title from " + BOOK_TABLE, String.class )
437436
.getResultList()
438-
.thenAccept( list -> assertTrue( list.get( 0 ) instanceof String ) ) )
437+
.thenAccept( list -> assertInstanceOf( String.class, list.get( 0 ) ) ) )
439438
.thenCompose( vv -> session
440439
.createNativeQuery( "select title, isbn, id from " + BOOK_TABLE )
441440
.getResultList()
442441
.thenAccept( list -> {
443442
Object[] tuple = (Object[]) list.get( 0 );
444443
assertEquals( 3, tuple.length );
445-
assertTrue( tuple[0] instanceof String );
444+
assertInstanceOf( String.class, tuple[0] );
446445
} ) )
447446
.thenCompose( vv -> session
448447
.createNativeQuery( "select title, isbn, id from " + BOOK_TABLE, Object[].class )
449448
.getResultList()
450449
.thenAccept( list -> {
451450
Object[] tuple = list.get( 0 );
452451
assertEquals( 3, tuple.length );
453-
assertTrue( tuple[0] instanceof String );
452+
assertInstanceOf( String.class, tuple[0] );
454453
} ) )
455454
.thenCompose( vv -> session
456455
.createNativeQuery( "select title, isbn, id from " + BOOK_TABLE, Tuple.class )
457456
.getResultList()
458457
.thenAccept( list -> {
459458
Tuple tuple = list.get( 0 );
460459
assertEquals( 3, tuple.toArray().length );
461-
assertTrue( tuple.get( 0 ) instanceof String );
462-
assertTrue( tuple.get( "isbn" ) instanceof String );
460+
assertInstanceOf( String.class, tuple.get( 0 ) );
461+
assertInstanceOf( String.class, tuple.get( "isbn" ) );
463462
} ) )
464463
)
465464
);
@@ -488,10 +487,10 @@ public void testNamedHqlProjectionQuery(VertxTestContext context) {
488487
.thenAccept( books -> {
489488
assertEquals( 3, books.size() );
490489
books.forEach( tuple -> {
491-
assertTrue( tuple instanceof Object[] );
490+
assertInstanceOf( Object[].class, tuple );
492491
assertEquals( 2, tuple.length );
493-
assertTrue( tuple[0] instanceof String );
494-
assertTrue( tuple[1] instanceof String );
492+
assertInstanceOf( String.class, tuple[0] );
493+
assertInstanceOf( String.class, tuple[1] );
495494
} );
496495
} )
497496

@@ -527,10 +526,10 @@ public void testNamedNativeProjectionQuery(VertxTestContext context) {
527526
.thenAccept( books -> {
528527
assertEquals( 3, books.size() );
529528
books.forEach( tuple -> {
530-
assertTrue( tuple instanceof Object[] );
529+
assertInstanceOf( Object[].class, tuple );
531530
assertEquals( 2, tuple.length );
532-
assertTrue( tuple[0] instanceof String );
533-
assertTrue( tuple[1] instanceof String );
531+
assertInstanceOf( String.class, tuple[0] );
532+
assertInstanceOf( String.class, tuple[1] );
534533
} );
535534
} )
536535
);
@@ -573,7 +572,7 @@ public void testSingleResultQueryException(VertxTestContext context) {
573572

574573
} )
575574
.handle( (r, x) -> {
576-
assertTrue( x.getCause() instanceof NoResultException );
575+
assertInstanceOf( NoResultException.class, x.getCause() );
577576
return null;
578577
} )
579578
);

0 commit comments

Comments
 (0)