DEPR: start with Deprecation instead of FutureWarning for NDFrame._data (pandas-dev#53994)

Author: jorisvandenbossche

pandas/core/generic.py

@@ -506,7 +506,7 @@ def _data(self):
         warnings.warn(
             f"{type(self).__name__}._data is deprecated and will be removed in "
             "a future version. Use public APIs instead.",
-            FutureWarning,
+            DeprecationWarning,
             stacklevel=find_stack_level(),
         )
         return self._mgr

pandas/tests/frame/test_api.py

@@ -379,6 +379,6 @@ def test_inspect_getmembers(self):
         df = DataFrame()
         msg = "DataFrame._data is deprecated"
         with tm.assert_produces_warning(
-            FutureWarning, match=msg, check_stacklevel=False
+            DeprecationWarning, match=msg, check_stacklevel=False
         ):
             inspect.getmembers(df)

pandas/tests/generic/test_generic.py

@@ -307,7 +307,7 @@ def test_copy_and_deepcopy(self, frame_or_series, shape, func):
     def test_data_deprecated(self, frame_or_series):
         obj = frame_or_series()
         msg = "(Series|DataFrame)._data is deprecated"
-        with tm.assert_produces_warning(FutureWarning, match=msg):
+        with tm.assert_produces_warning(DeprecationWarning, match=msg):
             mgr = obj._data
         assert mgr is obj._mgr
 

pandas/tests/series/test_api.py

@@ -172,7 +172,7 @@ def test_inspect_getmembers(self):
         ser = Series(dtype=object)
         msg = "Series._data is deprecated"
         with tm.assert_produces_warning(
-            FutureWarning, match=msg, check_stacklevel=False
+            DeprecationWarning, match=msg, check_stacklevel=False
         ):
             inspect.getmembers(ser)