Skip to content

Commit d5d3e45

Browse files
committed
fix(build): standardize comments and comment out uglify:dist
Standard the comment styles and add uglify to the css min commented block as it is not used anymore Fixes #455
1 parent 7d0d96d commit d5d3e45

File tree

1 file changed

+32
-34
lines changed

1 file changed

+32
-34
lines changed

Diff for: templates/common/Gruntfile.js

+32-34
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,9 @@ module.exports = function (grunt) {
162162
},<% } %>
163163
// not used since Uglify task does concat,
164164
// but still available if needed
165-
/*concat: {
166-
dist: {}
167-
},*/
165+
// concat: {
166+
// dist: {}
167+
// },
168168
rev: {
169169
dist: {
170170
files: {
@@ -210,31 +210,38 @@ module.exports = function (grunt) {
210210
}]
211211
}
212212
},
213-
cssmin: {
214-
// By default, your `index.html` <!-- Usemin Block --> will take care of
215-
// minification. This option is pre-configured if you do not wish to use
216-
// Usemin blocks.
217-
// dist: {
218-
// files: {
219-
// '<%%= yeoman.dist %>/styles/main.css': [
220-
// '.tmp/styles/{,*/}*.css',
221-
// '<%%= yeoman.app %>/styles/{,*/}*.css'
222-
// ]
223-
// }
224-
// }
225-
},
213+
// By default, your `index.html` <!-- Usemin Block --> will take care of
214+
// minification. This option is pre-configured if you do not wish to use
215+
// Usemin blocks.
216+
// cssmin: {
217+
// dist: {
218+
// files: {
219+
// '<%%= yeoman.dist %>/styles/main.css': [
220+
// '.tmp/styles/{,*/}*.css',
221+
// '<%%= yeoman.app %>/styles/{,*/}*.css'
222+
// ]
223+
// }
224+
// }
225+
// },
226+
// uglify: {
227+
// dist: {
228+
// files: {
229+
// '<%%= yeoman.dist %>/scripts/scripts.js': [
230+
// '<%%= yeoman.dist %>/scripts/scripts.js'
231+
// ]
232+
// }
233+
// }
234+
// },
226235
htmlmin: {
227236
dist: {
228237
options: {
229-
/*removeCommentsFromCDATA: true,
230-
// https://github.com/yeoman/grunt-usemin/issues/44
231-
//collapseWhitespace: true,
232-
collapseBooleanAttributes: true,
233-
removeAttributeQuotes: true,
234-
removeRedundantAttributes: true,
235-
useShortDoctype: true,
236-
removeEmptyAttributes: true,
237-
removeOptionalTags: true*/
238+
// removeCommentsFromCDATA: true,
239+
// collapseBooleanAttributes: true,
240+
// removeAttributeQuotes: true,
241+
// removeRedundantAttributes: true,
242+
// useShortDoctype: true,
243+
// removeEmptyAttributes: true,
244+
// removeOptionalTags: true*/
238245
},
239246
files: [{
240247
expand: true,
@@ -315,15 +322,6 @@ module.exports = function (grunt) {
315322
dest: '.tmp/concat/scripts'
316323
}]
317324
}
318-
},
319-
uglify: {
320-
dist: {
321-
files: {
322-
'<%%= yeoman.dist %>/scripts/scripts.js': [
323-
'<%%= yeoman.dist %>/scripts/scripts.js'
324-
]
325-
}
326-
}
327325
}
328326
});
329327

0 commit comments

Comments
 (0)