Skip to content

Commit 56fe9bb

Browse files
ENH: Add new "default" engine argument when notes is not None (openpyxl engine) (pandas-dev#58070)
Co-Authored-By: Dacops <[email protected]>
1 parent 702eefa commit 56fe9bb

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

pandas/io/excel/_base.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -510,17 +510,14 @@ def read_excel(
510510
if engine_kwargs is None:
511511
engine_kwargs = {}
512512

513-
# set to false so cells have a comment attribute
514-
if notes is not None and engine == "openpyxl":
515-
engine_kwargs = {"read_only": False}
516-
517513
if not isinstance(io, ExcelFile):
518514
should_close = True
519515
io = ExcelFile(
520516
io,
521517
storage_options=storage_options,
522518
engine=engine,
523519
engine_kwargs=engine_kwargs,
520+
notes=notes,
524521
)
525522
elif engine and engine != io.engine:
526523
raise ValueError(
@@ -1606,6 +1603,7 @@ def __init__(
16061603
engine: str | None = None,
16071604
storage_options: StorageOptions | None = None,
16081605
engine_kwargs: dict | None = None,
1606+
notes: DataFrame | None = None,
16091607
) -> None:
16101608
if engine_kwargs is None:
16111609
engine_kwargs = {}
@@ -1651,6 +1649,10 @@ def __init__(
16511649
assert engine is not None
16521650
self.engine = engine
16531651
self.storage_options = storage_options
1652+
1653+
# set to false so cells have a comment attribute
1654+
if notes is not None and engine=='openpyxl':
1655+
engine_kwargs = {**{"read_only": False},**engine_kwargs}
16541656

16551657
self._reader = self._engines[engine](
16561658
self._io,

0 commit comments

Comments
 (0)