Cleaning up pylint errors

Author: DJDevon3

adafruit_is31fl3731/__init__.py

@@ -104,7 +104,7 @@ class IS31FL3731:
     width: int = 16
     height: int = 9
 
-    def __init__(self, i2c: busio.I2C, address: int = 0x74, frames: int = None) -> None:
+    def __init__(self, i2c: None, address: int = 0x74, frames: int = None) -> None:
         self.i2c_device = I2CDevice(i2c, address)
         self._frame = None
         self._init(frames=frames)
@@ -325,7 +325,7 @@ def pixel_addr(x, y):
         """Calulate the offset into the device array for x,y pixel"""
         return x + y * 16
 
-    # pylint: disable-msg=too-many-arguments
+    # pylint: disable-msg=too-many-arguments, too-many-branches
     def pixel(
         self,
         x: int,
@@ -350,27 +350,27 @@ def pixel(
             raise ValueError("Rotation must be 0, 90, 180, or 270 degrees")
 
         if rotate == 0:
-            if not 0 <= x <= self.width:
-                return None
-            if not 0 <= y <= self.height:
+            check_x = 0 <= x <= self.width
+            check_y = 0 <= y <= self.height
+            if not (check_x and check_y):
                 return None
             pixel = self.pixel_addr(x, y)
         elif rotate == 90:
-            if not 0 <= y <= self.width:
-                return None
-            if not 0 <= x <= self.height:
+            check_x = 0 <= y <= self.width
+            check_y = 0 <= x <= self.height
+            if not (check_x and check_y):
                 return None
             pixel = self.pixel_addr(y, self.height - x - 1)
         elif rotate == 180:
-            if not 0 <= x <= self.width:
-                return None
-            if not 0 <= y <= self.height:
+            check_x = 0 <= x <= self.width
+            check_y = 0 <= y <= self.height
+            if not (check_x and check_y):
                 return None
             pixel = self.pixel_addr(self.width - x - 1, self.height - y - 1)
         elif rotate == 270:
-            if not 0 <= y <= self.width:
-                return None
-            if not 0 <= x <= self.height:
+            check_x = 0 <= y <= self.width
+            check_y = 0 <= x <= self.height
+            if not (check_x and check_y):
                 return None
             pixel = self.pixel_addr(self.width - y - 1, x)
 
@@ -410,9 +410,7 @@ def image(self, img: bytes = None, blink: bool = False, frame: int = 0) -> bytes
         imwidth, imheight = img.size
         if imwidth != self.width or imheight != self.height:
             raise ValueError(
-                "Image must be same dimensions as display ({0}x{1}).".format(
-                    self.width, self.height
-                )
+                f"Image must be same dimensions as display {self.width}x{self.height}"
             )
         # Grab all the pixels from the image, faster than getpixel.
         pixels = img.load()

adafruit_is31fl3731/matrix.py

@@ -30,7 +30,7 @@
 from . import IS31FL3731
 
 try:
-    from typing import TYPE_CHECKING, List, Tuple
+    from typing import TYPE_CHECKING
 
     if TYPE_CHECKING:
         from circuitpython_typing import ReadableBuffer
@@ -69,13 +69,11 @@ def image(self, img: str = None, blink: bool = False, frame: int = 0):
             raise ValueError("Image must be in mode L.")
         if img.size[0] != self.width or img.size[1] != self.height:
             raise ValueError(
-                "Image must be same dimensions as display ({0}x{1}).".format(
-                    self.width, self.height
-                )
+                f"Image must be same dimensions as display {self.width}x{self.height}"
             )
 
         # Frame-select and then write pixel data in one big operation
-        if frame is not 0:
+        if frame != 0:
             self._bank(frame)
         # We can safely reduce the image to a "flat" byte sequence because
         # the matrix layout is known linear; no need to go through a 2D

examples/is31fl3731_16x9_charlieplexed_pwm.py

@@ -1,7 +1,7 @@
 # SPDX-FileCopyrightText: 2024 DJDevon3
 # SPDX-License-Identifier: MIT
 """ Adafruit 16x9 Charlieplexed PWM LED Matrix Example """
-
+# pylint: disable=import-error
 import board
 import adafruit_framebuf
 
@@ -14,28 +14,28 @@
 i2c = board.STEMMA_I2C()
 display = Display(i2c, address=0x74)
 
-pixel_rotation = 90  # display rotation (0,90,180,270)
-pixel_brightness = 20  # values (0-255)
-pixel_blink = False  # blink entire display
+PIXEL_ROTATION = 0  # display rotation (0,90,180,270)
+PIXEL_BRIGHTNESS = 20  # values (0-255)
+PIXEL_BLINK = False  # blink entire display
 
-text_to_show = "Hello World!"  # Scrolling marquee text
+TEXT = "Hello World!"  # Scrolling marquee text
 
 print(f"Display Dimensions: {display.width}x{display.height}")
-print(f"Text: {text_to_show}")
+print(f"Text: {TEXT}")
 
 # Create a framebuffer for our display
 buf = bytearray(32)  # 2 bytes tall x 16 wide = 32 bytes (9 bits is 2 bytes)
 buffer = adafruit_framebuf.FrameBuffer(
     buf, display.width, display.height, adafruit_framebuf.MVLSB
 )
 
-frame = 0  # start with frame 0
+FRAME = 0  # start with frame 0
 while True:
     # Looping marquee
-    for i in range(len(text_to_show) * 9):
+    for i in range(len(TEXT) * 9):
         buffer.fill(0)
-        buffer.text(text_to_show, -i + display.width, 0, color=1)
-        display.frame(frame, show=False)
+        buffer.text(TEXT, -i + display.width, 0, color=1)
+        display.frame(FRAME, show=False)
         display.fill(0)
         for x in range(display.width):
             # using the FrameBuffer text result
@@ -45,5 +45,5 @@
                 # if bit > 0 then set the pixel brightness
                 if bit:
                     display.pixel(
-                        x, y, pixel_brightness, blink=pixel_blink, rotate=pixel_rotation
+                        x, y, PIXEL_BRIGHTNESS, blink=PIXEL_BLINK, rotate=PIXEL_ROTATION
                     )