Explain getRootIdent/ObjectOf/Pos check

MichaelUrman · MichaelUrman · commit 69e9ae12fcc9 · 2024-05-29T10:26:10.000-05:00
diff --git a/pkg/analyzer/analyzer.go b/pkg/analyzer/analyzer.go
@@ -55,10 +55,11 @@ func run(pass *analysis.Pass) (interface{}, error) {
 				break
 			}
 
+			// allow assignment to non-pointer children of values defined within the loop
 			if lhs := getRootIdent(pass, assignStmt.Lhs[0]); lhs != nil {
 				if obj := pass.TypesInfo.ObjectOf(lhs); obj != nil {
 					if obj.Pos() >= body.Pos() && obj.Pos() < body.End() {
-						continue
+						continue // definition is within the loop
 					}
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -55,10 +55,11 @@ func run(pass *analysis.Pass) (interface{}, error) {`
`55`	`55`	`break`
`56`	`56`	`}`
`57`	`57`
	`58`	`+ // allow assignment to non-pointer children of values defined within the loop`
`58`	`59`	`if lhs := getRootIdent(pass, assignStmt.Lhs[0]); lhs != nil {`
`59`	`60`	`if obj := pass.TypesInfo.ObjectOf(lhs); obj != nil {`
`60`	`61`	`if obj.Pos() >= body.Pos() && obj.Pos() < body.End() {`
`61`		`- continue`
	`62`	`+ continue // definition is within the loop`
`62`	`63`	`}`
`63`	`64`	`}`
`64`	`65`	`}`