Skip to content

Remove duplicates before matching #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
urirot opened this issue Sep 2, 2020 · 2 comments
Closed

Remove duplicates before matching #117

urirot opened this issue Sep 2, 2020 · 2 comments
Assignees
@bbucior @mtdamert

Comments

@urirot
Copy link
Collaborator

urirot commented Sep 2, 2020

  • When matching from a data source, each source should have unique id's for what we are matching.
  • This should be generic to all data sources, but currently can be done only on petpoint.
  • The column in petpoint that is named outcome_person_num should become unique for matching purposes.
@urirot urirot assigned urirot, bbucior and mtdamert and unassigned urirot Sep 2, 2020
@bbucior
Copy link
Collaborator

bbucior commented Oct 13, 2020

@urirot I think this should now be covered from 1f73133. It looks like when we load each PP/SF/etc table, the matching code will only consider the unique combinations of ID + name + email

@urirot
Copy link
Collaborator Author

urirot commented Oct 16, 2020

@bbucior got it. closing

@urirot urirot closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbucior bbucior

@mtdamert mtdamert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@urirot @bbucior @mtdamert