Skip to content

Commit 0835858

Browse files
committed
Fix nit
Rewrite it to not use `if let`.
1 parent 05a22a7 commit 0835858

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/libstd/sys/windows/args.rs

+6-4
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,14 @@ unsafe fn parse_lp_cmd_line<F: Fn() -> OsString>(lp_cmd_line: *const u16, exe_na
7272
QUOTE => {
7373
loop {
7474
i += 1;
75-
if *lp_cmd_line.offset(i) == 0 {
75+
let c = *lp_cmd_line.offset(i);
76+
if c == 0 {
7677
ret_val.push(OsString::from_wide(
7778
slice::from_raw_parts(lp_cmd_line.offset(1), i as usize - 1)
7879
));
7980
return ret_val.into_iter();
8081
}
81-
if *lp_cmd_line.offset(i) == QUOTE {
82+
if c == QUOTE {
8283
break;
8384
}
8485
}
@@ -101,13 +102,14 @@ unsafe fn parse_lp_cmd_line<F: Fn() -> OsString>(lp_cmd_line: *const u16, exe_na
101102
_ => {
102103
loop {
103104
i += 1;
104-
if *lp_cmd_line.offset(i) == 0 {
105+
let c = *lp_cmd_line.offset(i);
106+
if c == 0 {
105107
ret_val.push(OsString::from_wide(
106108
slice::from_raw_parts(lp_cmd_line, i as usize)
107109
));
108110
return ret_val.into_iter();
109111
}
110-
if let 0...SPACE = *lp_cmd_line.offset(i) {
112+
if c > 0 && c <= SPACE {
111113
break;
112114
}
113115
}

0 commit comments

Comments
 (0)