Make the requested changes

Requested by @dhruvmanila

Author: CenTdemeern1

data_structures/stacks/stack.py

@@ -110,8 +110,7 @@ def test_stack() -> None:
     assert not stack.is_empty()
     assert stack.is_full()
     assert str(stack) == str(list(range(10)))
-    test = stack.pop()
-    assert test == 9
+    assert stack.pop() == 9
     assert stack.peek() == 8
 
     stack.push(100)

fuzzy_logic/fuzzy_operations.py

@@ -9,12 +9,7 @@
 """
 import numpy as np
 
-try:
-    import skfuzzy as fuzz
-except ImportError:
-    import sys
-
-    sys.exit()  # This is so the CI doesn't complain about an unknown library
+import skfuzzy as fuzz
 
 if __name__ == "__main__":
     # Create universe of discourse in Python using linspace ()

graphs/directed_and_undirected_(weighted)_graph.py

@@ -225,8 +225,6 @@ def has_cycle(self):
                                 anticipating_nodes.add(node[1])
                                 break
                             else:
-                                # FIXME: there used to be unreachable code here.
-                                # Code removed because of linter complaints.
                                 return True
                     if visited.count(node[1]) < 1:
                         stack.append(node[1])
@@ -452,8 +450,6 @@ def has_cycle(self):
                                 anticipating_nodes.add(node[1])
                                 break
                             else:
-                                # FIXME: there used to be unreachable code here.
-                                # Code removed because of linter complaints.
                                 return True
                     if visited.count(node[1]) < 1:
                         stack.append(node[1])

hashes/hamming_code.py

@@ -79,10 +79,7 @@ def emitterConverter(sizePar, data):
     ['1', '1', '1', '1', '0', '1', '0', '0', '1', '0', '1', '1', '1', '1', '1', '1']
     """
     if sizePar + len(data) <= 2**sizePar - (len(data) - 1):
-        print("ERROR - size of parity don't match with size of data")
-        import sys
-
-        sys.exit(0)
+        raise ValueError("ERROR - size of parity don't match with size of data")
 
     dataOut = []
     parity = []

maths/extended_euclidean_algorithm.py

@@ -75,11 +75,12 @@ def main():
     """Call Extended Euclidean Algorithm."""
     if len(sys.argv) < 3:
         print("2 integer arguments required")
-        sys.exit(1)
+        return 1
     a = int(sys.argv[1])
     b = int(sys.argv[2])
     print(extended_euclidean_algorithm(a, b))
+    return 0
 
 
 if __name__ == "__main__":
-    main()
+    raise SystemExit(main())

matrix/matrix_class.py

@@ -286,7 +286,7 @@ def add_column(self, column: list[int], position: int | None = None) -> None:
     # MATRIX OPERATIONS
     def __eq__(self, other: object) -> bool:
         if not isinstance(other, Matrix):
-            return False
+            return NotImplemented
         return self.rows == other.rows
 
     def __ne__(self, other: object) -> bool:

other/lfu_cache.py

@@ -264,8 +264,7 @@ def set(self, key: T, value: U) -> None:
                 # explain to type checker via assertions
                 assert first_node is not None
                 assert first_node.key is not None
-                remove_test = self.list.remove(first_node)
-                assert remove_test is not None
+                assert self.list.remove(first_node) is not None
                 # first_node guaranteed to be in list
 
                 del self.cache[first_node.key]

other/lru_cache.py

@@ -280,9 +280,8 @@ def set(self, key: T, value: U) -> None:
                 # explain to type checker via assertions
                 assert first_node is not None
                 assert first_node.key is not None
-                test_removal = self.list.remove(first_node)
                 assert (
-                    test_removal is not None
+                    self.list.remove(first_node) is not None
                 )  # node guaranteed to be in list assert node.key is not None
 
                 del self.cache[first_node.key]

project_euler/problem_067/sol1.py

@@ -28,8 +28,12 @@ def solution():
     with open(triangle) as f:
         triangle = f.readlines()
 
-    a = [x.rstrip("\r\n").split(" ") for x in triangle]
-    a = [[int(i) for i in x] for x in a]
+    a = []
+    for line in triangle:
+        numbers_from_line = []
+        for number in line.strip().split(" "):
+            numbers_from_line.append(int(number))
+        a.append(numbers_from_line)
 
     for i in range(1, len(a)):
         for j in range(len(a[i])):

project_euler/problem_099/sol1.py

@@ -25,8 +25,7 @@ def solution(data_file: str = "base_exp.txt") -> int:
     largest: float = 0
     result = 0
     for i, line in enumerate(open(os.path.join(os.path.dirname(__file__), data_file))):
-        a, x = line.split(",")
-        a, x = int(a), int(x)
+        a, x = list(map(int, line.split(",")))
         if x * log10(a) > largest:
             largest = x * log10(a)
             result = i + 1

scheduling/first_come_first_served.py

@@ -73,23 +73,21 @@ def calculate_average_waiting_time(waiting_times: list[int]) -> float:
 
 
 if __name__ == "__main__":
-    import sys
-
     # process id's
     processes = [1, 2, 3]
 
     # ensure that we actually have processes
     if len(processes) == 0:
         print("Zero amount of processes")
-        sys.exit()
+        raise SystemExit
 
     # duration time of all processes
     duration_times = [19, 8, 9]
 
     # ensure we can match each id to a duration time
     if len(duration_times) != len(processes):
         print("Unable to match all id's with their duration time")
-        sys.exit()
+        raise SystemExit
 
     # get the waiting times and the turnaround times
     waiting_times = calculate_waiting_times(duration_times)

scheduling/multi_level_feedback_queue.py

@@ -276,9 +276,7 @@ def multi_level_feedback_queue(self) -> deque[Process]:
     queue = deque([P1, P2, P3, P4])
 
     if len(time_slices) != number_of_queues - 1:
-        import sys
-
-        sys.exit()
+        raise SystemExit
 
     doctest.testmod(extraglobs={"queue": deque([P1, P2, P3, P4])})
 

web_programming/emails_from_url.py

@@ -93,9 +93,7 @@ def emails_from_url(url: str = "https://github.com") -> list[str]:
             except ValueError:
                 pass
     except ValueError:
-        import sys
-
-        sys.exit(-1)
+        raise SystemExit
 
     # Finally return a sorted list of email addresses with no duplicates.
     return sorted(valid_emails)