Refactored

Author: CelliesProjects

src/sensorTask.cpp

@@ -8,29 +8,51 @@ void sensorTask(void *parameter)
     DallasTemperature sensor(&oneWire);
 
     sensor.begin();
-    
+
     DeviceAddress sensorAddress;
 
     if (!sensor.getAddress(sensorAddress, 0))
     {
         log_d("No DS18B20 sensor found. Deleting task.");
         vTaskDelete(NULL);
     }
-
     sensor.setResolution(sensorAddress, 12);
-    sensor.requestTemperatures();
+
+    float lastTemperatureC = DEVICE_DISCONNECTED_C;
+    static int errorCount = 0;
 
     while (1)
     {
+        sensor.requestTemperatures();
+
         vTaskDelay(pdMS_TO_TICKS(750));
 
         const float temperatureC = sensor.getTempC(sensorAddress);
 
-        if (temperatureC != DEVICE_DISCONNECTED_C)
-            log_i("Temperature: %.2f°C", temperatureC);
-        else
+        if (temperatureC == DEVICE_DISCONNECTED_C)
+        {
             log_i("Sensor disconnected or error reading temperature.");
+            if (++errorCount >= 10)
+            {
+                log_e("Persistent sensor error after 10 retries. Deleting task.");
+                vTaskDelete(NULL);
+            }
+        }
+        else
+        {
+            errorCount = 0;
 
-        sensor.requestTemperatures();
+            if (fabs(temperatureC - lastTemperatureC) > TEMPERATURE_THRESHOLD)
+            {
+                lcdMessage_t msg;
+                msg.type = TEMPERATURE;
+                msg.float1 = temperatureC;
+
+                const BaseType_t result = xQueueSend(lcdQueue, &msg, 0);
+
+                log_i("%s lcd temperature %.2f°C", result ? "Updated" : "Could not update", temperatureC);
+                lastTemperatureC = result ? temperatureC : lastTemperatureC;
+            }
+        }
     }
 }

src/sensorTask.hpp

@@ -4,6 +4,12 @@
 #include <OneWire.h>
 #include <DallasTemperature.h>
 
+#include "lcdMessage_t.h"
+
+#define TEMPERATURE_THRESHOLD (0.1f)
+
+extern QueueHandle_t lcdQueue;
+
 static constexpr int ONE_WIRE_PIN = 26;
 
 #endif