Do not confuse warnings with errors on shapefile output

Closes #87

Author: Sandro Santilli

NEWS.md

@@ -1,5 +1,6 @@
 1.3.6 (DD/MM/YY)
 -----
+* Do not confuse warnings with errors on shapefile output (#87)
 
 1.3.5 (19/02/13)
 -----

app/controllers/app.js

@@ -571,9 +571,12 @@ console.log(['ogr2ogr',
         //console.log('stdout: ' + data);
       });
 
-      var stderr = '';
+      var stderr;
+      var logErrPat = new RegExp(/^ERROR/);
       child.stderr.on('data', function(data) {
-        stderr += data;
+        data = data.toString(); // know of a faster way ?
+        // Store only the first ERROR line
+        if ( ! stderr && data.match(logErrPat) ) stderr = data;
         console.log('ogr2ogr stderr: ' + data);
       });
 

test/acceptance/export/shapefile.js

@@ -204,6 +204,31 @@ test('mixed type geometry', function(done){
     });
 });
 
+// See https://github.com/Vizzuality/CartoDB-SQL-API/issues/87
+test('errors are not confused with warnings', function(done){
+    var query = querystring.stringify({
+        q: "SELECT 'POINT(0 0)'::geometry as g"
+         + ", 1 as a_very_very_very_long_field_name"
+         + " UNION ALL "
+         + "SELECT 'LINESTRING(0 0, 1 0)'::geometry, 2",
+        format: 'shp'
+      });
+    assert.response(app, {
+        url: '/api/v1/sql?' + query,
+        headers: {host: 'vizzuality.cartodb.com'},
+        encoding: 'binary',
+        method: 'GET'
+    },{ }, function(res){
+        assert.deepEqual(res.headers['content-type'], 'application/json; charset=utf-8');
+        assert.deepEqual(res.headers['content-disposition'], 'inline');
+        assert.equal(res.statusCode, 400, res.statusCode + ': ' +res.body);
+        var parsedBody = JSON.parse(res.body);
+        var expectedBody = {"error":["ERROR 1: Attempt to write non-point (LINESTRING) geometry to point shapefile."]}
+        assert.deepEqual(parsedBody, expectedBody);
+        done();
+    });
+});
+
 test('skipfields controls fields included in SHP output', function(done){
     var query = querystring.stringify({
         q: "SELECT 111 as skipme, 222 as keepme, 'POINT(0 0)'::geometry as g",