Skip to content

Ch 5 Dark World, Text equation uses min by code uses max #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZachariahRosenberg opened this issue Jan 19, 2021 · 1 comment
Closed

Comments

@ZachariahRosenberg
Copy link

In the text discussing Tim's decreasing function for euclidean distance, the formula is displayed as:

Screen Shot 2021-01-18 at 8 34 53 PM

This shows the minimum of the Euclidean distance and some value.

--

In the code (here shown as the PyMC3 version), the T.maximum is used:

def f_distance(gxy_pos, halo_pos, c):
    return T.maximum(euclidean_distance(gxy_pos, halo_pos), c)[:, None]

Shouldn't these two be the same?

Thanks!

@ZachariahRosenberg
Copy link
Author

closing since this has gone stale.

@ZachariahRosenberg ZachariahRosenberg closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant